Added a reply to your nit. I don't see any trouble down the line with this one
- anybody who fiddles with that code should know how the tags work in any case.
Thanks for testing!
@bunnybot merge
Diff comments:
>
> === modified file 'src/graphic/text_layout.cc'
> --- src/graphic/text_layout.cc
Good idea - done :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1685331-barracks_old_saves/+merge/323481
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1685331-barracks_old_saves.
The proposal to merge lp:~widelands-dev/widelands/bug-1685331-oldsaves into
lp:widelands has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1685331-oldsaves/+merge/323442
--
Your team Widelands Developers is subs
Thanks for testing and review :-)
Got also all emails (except for the server error).
Deferred vs. Immediate mails: I have tried to use deferred mails for things
where 'maybe' much people get informed. I just guessed that most people are
interested in getting e-mails for new maps, topics and for
Review: Approve
Some comments while testing:
- On http://alpha.widelands.org/notification/, the maps heading says Wlmaps.
That should probably just read Maps.
- I sent myself a PM and got an email immediately.
- I subscribed to the forum and created a new topic.
- When uploading a map I got a 50
Review: Approve test, compile, review
Played this now some 1,5 hours or such,
noticed no direct Problems.
Code LGTM, expect an inline nit.
But I still do noth know enough about that HTML like text-handling,
do really understang what happens here.
Diff comments:
>
> === modified file 'src/graph
Review: Approve
Code looks good and it seems to work fine. Tested it with b19 savegames with
and without ports and with a current scenario savegame.
A small remark: Increasing "tribe_buildings" could probably be replaced with
"player->tribe().buildings().size()".
--
https://code.launchpad.net/~
Maybe you could find an answer why the pickle warning shows up. The relevant
code for pickling is:
http://bazaar.launchpad.net/~widelands-dev/widelands-website/notifications_cleanup/view/head:/notification/models.py#L310
For unpickling:
http://bazaar.launchpad.net/~widelands-dev/widelands-websi
Continuous integration builds have changed state:
Travis build 2141. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/227855101.
Appveyor build 1976. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_168533
The proposal to merge
lp:~widelands-dev/widelands/bug-1655168-statistics-overlap into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1655168-statistics-overlap/+merge/323441
--
Your team Widelands
I fixed the other branch for scenarios - please have a look:
https://code.launchpad.net/~widelands-dev/widelands/bug-1685331-always-enable/+merge/323481
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1685331-oldsaves/+merge/323442
Your team Widelands Developers is subscribed to branch
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1685331-always-enable into lp:widelands.
Commit message:
Savegame compatibility: If the Barracks is the only building not allowed when
loading a savegame, allow it.
Requested reviews:
Notabilis (notabilis27)
Related bugs:
Bug #1
The proposal to merge
lp:~widelands-dev/widelands/bug-1655168-statistics-overlap into lp:widelands
has been updated.
Commit Message changed to:
Fixed statistics label overlap. Ware statistics now update their plot range
correctly.
For more details, see:
https://code.launchpad.net/~widelands-d
13 matches
Mail list logo
