Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1_width_and_mapobject_messages into lp:widelands

2017-04-24 Thread SirVer
Review: Needs Fixing Looking over the code, a few comments: 1) What is up with barbarians/warehouse/representative image? Why is this only for the barbarian warehouse in this branch? 2) I made DesiredWidth a struct, since it always appeared in a tuple of (int, unit). 3) I found a memory leak th

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1685645-workertable into lp:widelands

2017-04-24 Thread bunnybot
Continuous integration builds have changed state: Travis build 2117. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/225405310. Appveyor build 1952. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_168564

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1685645-workertable into lp:widelands

2017-04-24 Thread Notabilis
Notabilis has proposed merging lp:~widelands-dev/widelands/bug-1685645-workertable into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1685645 in widelands: "Workertable in buildings is broken" https://bugs.launchpad.net/widelands/+bug/1685645 For