Continuous integration builds have changed state:
Travis build 2116. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/225038488.
Appveyor build 1951. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_166405
> Colors are reversed between the Fullscreen menus and the in.game menus on
> purpose. This is necessary because the background makes non-bold text
> unreadable in the Fullscreen menus
Can't follow you here. The Save game menu shows currently (in this branch) bold
white constants ('Map name:') w
The proposal to merge lp:~widelands-dev/widelands/bug-1512093-workers into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1512093-workers/+merge/322981
--
Your team Widelands Developers is subscrib
Thanks for the review :)
The crash looks unfamiliar, I'll have to look into this.
> Is there a reason that Bob::calc_drawpos() (and derived methods) are still
> returning floats?
Yes, these are there for the zoom function, map elements can now end up not
being positioned pixel perfect.
> U
Colors are reversed between the Fullscreen menus and the in.game menus on
purpose. This is necessary because the background makes non-bold text
unreadable in the Fullscreen menus - the coloring is consistent with the
mapselect screen though.
I used the arrow in the replay in an attempt to signa
OK, let's merge this then :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1512093-workers/+merge/322981
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1512093-workers.
___
Mailing l
The diff looks okay to me and a short test game hasn't shown any optical
glitches. But... ;-)
Three minor remarks code-wise:
- Is there a reason that Bob::calc_drawpos() (and derived methods) are still
returning floats? Since it returns the pixel position on the screen I guess it
is always an i
You can ignore the something wrong here? bit. I am only resetting the
expedition status, not giving any new commands to the Ai ship. So, the ship
will be waiting until the AI issues the next round of commands.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1678598-expedition-no-eco-c
Continuous integration builds have changed state:
Travis build 2114. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/224895585.
Appveyor build 1949. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_167859
Review: Approve code revie, compile, test
Original Nile crash now shows:
5: Azurea Sea at 101x100: END OF EXPEDITION without port, continue exploring
5: last command for ship Azurea Sea at 102x102 was 41518 seconds ago,
something wrong here?...
5: Azurea Sea at 102x102: explore uphold, visited
The proposal to merge
lp:~widelands-dev/widelands/bug-1678598-expedition-no-eco-crash into
lp:widelands has been updated.
Commit Message changed to:
Only cancel expedition if there is a reachable portdock.
- Reset the expedition state to "Waiting" if no portdock could be found
- Show a warning
1st Code Review
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1678598-expedition-no-eco-crash/+merge/323004
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1678598-expedition-no-eco-crash into
lp:widelands.
___
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1678598-expedition-no-eco-crash into
lp:widelands.
Commit message:
Only cancel expedition if there is a reachable portdock.
- Reset the expedition state to "Waiting" if no portdock could be found
- Show a warning message to owner
- A
The proposal to merge lp:~widelands-dev/widelands/save_refactor into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/save_refactor/+merge/322622
--
Your team Widelands Developers is subscribed to branch
14 matches
Mail list logo
