The proposal to merge lp:~widelands-dev/widelands/bug-1664145-miners into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1664145-miners/+merge/317710
--
Your team Widelands Developers is subscribed
Thanks for the review :)
You make a good point about the glitch.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1664145-miners/+merge/317710
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1664145-miners.
__
Review: Approve
Oh, I overlooked
As for the mentioned glitch - it is questionable if the fetching higher worker
should be always preferred to creation of a new worker. I think mines right now
are not able to switch higher worker for a spare lower worker to make the
higher one available in case
I marked up the line with the fix.
The tiny glitch is probably the result of a complex economy and a lot harder to
track down. Can you reproduce it reliably? If so, we can add the info to the
bug and keep the bug open.
Diff comments:
> === modified file 'src/logic/map_objects/tribes/warehouse.
The proposal to merge lp:~widelands-dev/widelands/string-fixes into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/316931
--
Your team Widelands Developers is subscribed to branch
Gun, I can not see where in the code/diff you had changed anything..
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1664145-miners/+merge/317710
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1664145-miners into lp:widelands
Tested today and appears to work correctly now. There was a tiny glitch in that
2 Master Miners (out of 7) remained at home despite new Miner posts requested;
instead new Miners were created. We cannot say at this point where exactly this
error lies, assuming it is an error. However, I would sug
Thanks for reviewing again :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/316931
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
___
Mailing list: https://
Review: Approve testing
Works again :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1653254-flagaction-roads/+merge/317709
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1653254-flagaction-roads.
Review: Approve
Thanks for the campaign fixes, the diff looks good to me now.
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/316931
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
__
Continuous integration builds have changed state:
Travis build 1967. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/203050448.
Appveyor build 1802. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_crystal_mi
11 matches
Mail list logo
