The proposal to merge lp:~widelands-dev/widelands/automate_clang-format into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/automate_clang-format/+merge/312287
--
Your team Widelands Developers is subs
GunChleoc has proposed merging
lp:~widelands-dev/widelands-website/pyformat_util into lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Added script to ru
Thanks for the review!
So, pyformat doesn't fix long lines, need to keep that in mind.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/automate_clang-format/+merge/312287
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/automate_clang-for
Bunnybot encountered an error while working on this merge proposal:
[Errno 110] Connection timed out
--
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_201611/+merge/311329
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/compiler_warnings_
Notabilis has proposed merging
lp:~widelands-dev/widelands/feature-test-supply-crash into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1639444 in widelands: "Workers with wares inside ships can crash the
game"
https://bugs.launchpad.net/widelands
Notabilis has proposed merging lp:~widelands-dev/widelands/bug-supply into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1639444 in widelands: "Workers with wares inside ships can crash the
game"
https://bugs.launchpad.net/widelands/+bug/1639444
Review: Approve
pretty hard to review this diff with the formatting changes. I found two nits,
I think otherwise this is ready to merge.
Diff comments:
> === renamed file 'utils/fix_lua_tabs.py' => 'utils/fix_formatting.py'
> --- utils/fix_lua_tabs.py 2015-10-31 12:11:44 +
> +++ utils/
Review: Resubmit
Done. Never mind the big diff for udate_authors.py, the relevant bit is the
removed call at the bottom. Pyformat already in action here ;)
--
https://code.launchpad.net/~widelands-dev/widelands/automate_clang-format/+merge/312287
Your team Widelands Developers is subscribed to b
GunChleoc has proposed merging
lp:~widelands-dev/widelands/automate_clang-format into lp:widelands.
Commit message:
Moved utils/fix_lua_tabs.py to utils/fix_formatting.py and added calls to
clang-format any pyformat.
Requested reviews:
GunChleoc (gunchleoc)
SirVer (sirver)
For more details
The proposal to merge lp:~widelands-dev/widelands/automate_clang-format into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/automate_clang-format/+merge/312287
--
Your team Widelands Develope
Will do that in this branch then.
--
https://code.launchpad.net/~widelands-dev/widelands/automate_clang-format/+merge/312287
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/automate_clang-format.
___
Mailing list: htt
Sgtm.
> Am 03.12.2016 um 14:39 schrieb GunChleoc :
>
> Thanks - all fixed.
>
> I was just thinking - we also have fix_lua_tabs.py, which is run when we
> update the translations.
>
> How about having 1 central script "fix_formating.py" that does the following:
>
> - fix_lua_tabs.py
> - run_c
Thanks - all fixed.
I was just thinking - we also have fix_lua_tabs.py, which is run when we update
the translations.
How about having 1 central script "fix_formating.py" that does the following:
- fix_lua_tabs.py
- run_clang_format.py
- run pyformat over utils.
This script could then be calle
13 matches
Mail list logo
