Continuous integration builds have changed state:
Travis build 1619. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/176633949.
Appveyor build 1457. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_863185
Bunnybot encountered an error while working on this merge proposal:
('The read operation timed out',)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-863185-census-on-destroyed-building/+merge/309818
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bu
Review: Approve
some minor nits in the code.
This is way better encapsulated than before, but it still does not make me all
warm and fuzzy inside - it feels weird that the animation passes out its
calculated source rect, just to get it back in the blitting call. I do not have
any more immediat
Review: Approve
just drive by to say thanks to notabilis to also pick up some reviews! that is
really awesome and shows great citizenship.
This is a good change and moving away from macros towards functions is
definitively the right direction! Just skimming the diff I wondered if
toolbar::add_
Continuous integration builds have changed state:
Travis build 1632. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/177718951.
Appveyor build 1470. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_toolbar_cl
I can confirm the fixed crash. Since the crash is gone and the spacing is back
I would say the branch is ready for merge. That is, if you design change is
planned for another branch.
--
https://code.launchpad.net/~widelands-dev/widelands/toolbar_cleanup/+merge/35
Your team Widelands Develope
Should be fixed now.
Good point about the editor toolbar - I have had an idea for a design change
now though, so I'd rather not spend and time on it right now.
I also noticed the button flicker, but I didn't find a ready fix for it. Since
it's already in trunk - a problem for another day.
--
h
7 matches
Mail list logo
