Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/b19-appid into lp:widelands/build19

2016-11-09 Thread Tino
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/b19-appid/+merge/310135 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/b19-appid into lp:widelands/build19. ___ Mailing list

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands

2016-11-09 Thread Notabilis
Nooo, not the beer! I liked the beer! :( But thanks for the review. The small stuff (renaming, etc.) is done, what is left are the bigger changes. Open problems in no particular order: 1) Making WorkersQueue more similar to WaresQueue and replacing the user interface should be no problem. I wil

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-09 Thread TiborB
Well, current logic was that if known portspace is found, the ship with probability of 50% search for open sea and if found it sails this direction. Otherwise it sail (keep on sailing) around the current land. I was afraid that ship can end up in a kind of ping-pong between two ports - but this

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-09 Thread TiborB
and yes, current expedition logic is really very primitive -- https://code.launchpad.net/~7010622-q/widelands/topple-seafaring-1/+merge/310436 Your team Widelands Developers is requested to review the proposed merge of lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands. ___

[Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-09 Thread bunnybot
Continuous integration builds have changed state: Travis build 1587. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/174511687. Appveyor build 1425. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_7010622_q_widelands_topple_seafari

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-09 Thread toptopple
repeat_island_prob is a repetition probability polled when a ship hits an island at a spot which was encountered before. So it is quaranteed that an island is at least circled once (when being found). repeat_island_prob is not a cessation probability, which it would have to be to justify your c

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/scrollbar_beautification into lp:widelands

2016-11-09 Thread bunnybot
Continuous integration builds have changed state: Travis build 1569. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/172860675. Appveyor build 1408. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_scrollbar_

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/scrollbar_beautification into lp:widelands

2016-11-09 Thread bunnybot
Bunnybot encountered an error while working on this merge proposal: ('The read operation timed out',) -- https://code.launchpad.net/~widelands-dev/widelands/scrollbar_beautification/+merge/309635 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/scrollbar_beautif

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-09 Thread TiborB
in regard to repeat_island_prob - so once the ship is on a coast of he will circle around it forever and never leave it to search for other lands/islands? -- https://code.launchpad.net/~7010622-q/widelands/topple-seafaring-1/+merge/310436 Your team Widelands Developers is requested to review the

[Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-09 Thread toptopple
toptopple has proposed merging lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~7010622-q/widelands/topple-seafaring-1/+merge/310436 Expedition strategy is quite weak at pre

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands

2016-11-09 Thread GunChleoc
Sorry, overlooked your comment - think now that the UI change should go in before the merge, because the code changes for that will be rather big, and we should get a superclass for wares and workers queues. For the documentation, see https://bazaar.launchpad.net/~widelands-dev/widelands/trunk