First round of code review is done - see my last commit.
I will have to look into your economy questions - I'm not really familiar with
the economy code myself yet.
Great contribution overall! I have mostly some minors nits and refactoring
ideas - feel free to drop any of those if you don't agr
I split up the documentation and updated some references. Now I am only
wondering: Is there a script which extracts this documentation somewhere? I
only found some generic documentation but no list of provided Lua classes or
something like that.
What else is to do in this branch? Will the UI be
Looks like your inline comment wasn't saved :(
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1624216-horsepocalypse/+merge/310221
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1624216-horsepocalypse into lp:widelands.
___
Code looks good to me, no Idea if that inline comment will help.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1624216-horsepocalypse/+merge/310221
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1624216-horsepocalypse into
The documentation is not dead. Various classes implement this interface and
refer to this as documentation.
We can delete this, but then we have to add the same documentation to all
classes that implement the semantics. As long as they do not diverge, I think
having them only documented once i
I think we should delete the documentation then - no need to have dead code
documented, it is confusing.
--
https://code.launchpad.net/~widelands-dev/widelands/casern_workersqueue/+merge/309763
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/wideland
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/sitemap into
lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #358452 in Widelands Website: "Sitemap.xml is missing"
https://bugs.launchpad.net/widelands-website/+bug/358452
Fo
7 matches
Mail list logo
