[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1570094_resource into lp:widelands

2016-04-14 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug_1570094_resource into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug_1570094_resource/+merge/291913 -- Your team Widelands Developers is subscr

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_156675_editor_initial_tool into lp:widelands

2016-04-14 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug_156675_editor_initial_tool into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug_156675_editor_initial_tool/+merge/291920 -- Your team Widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1570094_resource into lp:widelands

2016-04-14 Thread GunChleoc
Review: Approve LGTM :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug_1570094_resource/+merge/291913 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug_1570094_resource. ___ Mailing lis

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_156675_editor_initial_tool into lp:widelands

2016-04-14 Thread GunChleoc
Review: Approve LGTM :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug_156675_editor_initial_tool/+merge/291920 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug_156675_editor_initial_tool. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_156675_editor_initial_tool into lp:widelands

2016-04-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 1010. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/123111973. Appveyor build 843. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_156675_

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1570094_resource into lp:widelands

2016-04-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 1009. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/123106502. Appveyor build 842. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1570094

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/test-ngettext into lp:widelands

2016-04-14 Thread Miroslav Remák
Ok, sounds good to me. -- https://code.launchpad.net/~widelands-dev/widelands/test-ngettext/+merge/291587 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/test-ngettext. ___ Mailing list: https://launchpad.net/~widelan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/test-ngettext into lp:widelands

2016-04-14 Thread GunChleoc
Because the units appear in a longer sentence, I am in favour of having long unit names rather than symbols. Let's disallow the float and remove the placeholders. I can do that in his branch. -- https://code.launchpad.net/~widelands-dev/widelands/test-ngettext/+merge/291587 Your team Widelands D

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/test-ngettext into lp:widelands

2016-04-14 Thread Miroslav Remák
I fully agree with GunChleoc regarding Klaus' post. In Slovak we would say "twenty-five whole (ones) (and) six tenths of a second" and write "25,6 sekundy", where "sekundy" is the genitive case form of the word second. That's why a special plural form is needed. As for the merge request, I will

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_156675_editor_initial_tool into lp:widelands

2016-04-14 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands/bug_156675_editor_initial_tool into lp:widelands. Commit message: Use info tool as initial tool for the editor Fixes bug 1566675 Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1566675 in widelands: "Starti

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_156675_editor_initial_tool into lp:widelands

2016-04-14 Thread kaputtnik
The proposal to merge lp:~widelands-dev/widelands/bug_156675_editor_initial_tool into lp:widelands has been updated. Commit Message changed to: Use info tool as initial tool for the editor Fixes bug 1566675 For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug_156675_e

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1570094_resource into lp:widelands

2016-04-14 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands/bug_1570094_resource into lp:widelands. Commit message: Fix for resource tool bug 1570094 Removed comparisons of UInt < 0 Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1570094 in widelands: "Editor remo

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1560085-save-suggested-teams-display into lp:widelands

2016-04-14 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1560085-save-suggested-teams-display into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1560085-save-suggested-teams-display/+merge/291852 --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1560085-save-suggested-teams-display into lp:widelands

2016-04-14 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1560085-save-suggested-teams-display/+merge/291852 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1560085-save-suggested-teams-display. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1560085-save-suggested-teams-display into lp:widelands

2016-04-14 Thread Klaus Halfmann
Review: Approve review, compile, test Fixes the bug and improves variable names, fine. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1560085-save-suggested-teams-display/+merge/291852 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1560085-save