Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/network-memory into lp:widelands

2016-02-16 Thread SirVer
I think it would be better to just always keep a vector around and just keep it empty. Dealign with new/delete for vectors is fragile, and the vector has its memory on the heap anyways, so keeping it around is basically free. This is only a comment though, I have no time to properly dig into th

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/listselect into lp:widelands

2016-02-16 Thread bunnybot
Continuous integration builds have changed state: Travis build 713. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/109560748. Appveyor build 561. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_listselect-56

[Widelands-dev] [recipe build #1078195] of ~widelands-dev widelands-daily in xenial: Dependency wait

2016-02-16 Thread noreply
* State: Dependency wait * Recipe: widelands-dev/widelands-daily * Archive: ~widelands-dev/ubuntu/widelands-daily * Distroseries: xenial * Duration: 3 minutes * Build Log: https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+recipebuild/1078195/+files/buildlog.txt.gz * Uplo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1546095-backslash-edit into lp:widelands

2016-02-16 Thread kaputtnik
Funny behavior now: In authors field write "\text" the backslash could be seen. Make a space -> the backslash disappear. Write "\\" and a space, the last backslash disappear. Hit Backspace the last Backslash appears again. In the Description it is similar and sometimes when positioning the curso

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1509172-map-saving-paths into lp:widelands

2016-02-16 Thread bunnybot
Continuous integration builds have changed state: Travis build 709. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/109475085. Appveyor build 558. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1509172_m

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1546095-backslash-edit into lp:widelands

2016-02-16 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1546095-backslash-edit into lp:widelands. Commit message: Fixed crash when editor text field ends in \. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1546095 in widelands: "Crash when typing "\" in Ed

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1542705 into lp:widelands

2016-02-16 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1542705 into lp:widelands. Commit message: Renamed program "geologist-find" to "geologist_find" and "playFX" to "play_sound". Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1542705 in widelands: "Cons

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/add_hints into lp:widelands-website

2016-02-16 Thread GunChleoc
Looks good :) -- https://code.launchpad.net/~widelands-dev/widelands-website/add_hints/+merge/285664 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/add_hints into lp:widelands-website

2016-02-16 Thread kaputtnik
Thanks :-) Done. -- https://code.launchpad.net/~widelands-dev/widelands-website/add_hints/+merge/285664 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : wi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/add_hints into lp:widelands-website

2016-02-16 Thread GunChleoc
Just one style change that I would make: With very short descriptions and small maps, the "Hint" header is aligned beside the minimap image, but the hint text below the minimap. So, align everything to leave space for the image, or show the hint header + text below the image. -- https://code.l

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395278-underscores into lp:widelands

2016-02-16 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1395278-underscores into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-underscores/+merge/286114 -- Your team Widelands Developers is

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395278-underscores into lp:widelands

2016-02-16 Thread GunChleoc
Travis went through. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-underscores/+merge/286114 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1395278-underscores. ___ Mailing l

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/network-memory into lp:widelands

2016-02-16 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/network-memory into lp:widelands. Commit message: InternetGaming::games() and InternetGaming::clients() now return nullptr instead of a new vector in case of a communication failure. Requested reviews: Widelands Developers (widelands-

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_campaign_loading into lp:widelands

2016-02-16 Thread GunChleoc
> I just checked and the extra_data packet is required to load the map images > that can be accessed using map:blub.png: http://bazaar.launchpad.net > /~widelands- > dev/widelands/trunk/view/7837/src/map_io/map_extradata_packet.cc#L43. So these > need to be reverted for sure. No, we don't need the

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1525706-artifacts into lp:widelands

2016-02-16 Thread GunChleoc
I still need help with this before we can go ahead: > I tried and failed to just iterate over the fields - seems like there is no > way to safely get the size of a std::unique_ptr. > > Why is it an array and not a vector anyway? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1525706-

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/add_hints into lp:widelands-website

2016-02-16 Thread kaputtnik
Thanks for your offer SirVer :-) I am bit scary to act on the server... and i am bit slow because of that (checking each command three times ;) ). But i applied the changes now on the alpha site. Please test it: http://alpha.widelands.org/maps/ Upload a map which contain text in the hint field,