[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1544864 into lp:widelands

2016-02-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 691. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/109182358. Appveyor build 542. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1544864-

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395278-network into lp:widelands

2016-02-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 690. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/109176686. Appveyor build 541. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1395278_

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/syncstream_on_option into lp:widelands

2016-02-14 Thread SirVer
SirVer has proposed merging lp:~widelands-dev/widelands/syncstream_on_option into lp:widelands. Commit message: - Remove --remove-replays and --remove-syncstreams. We now always delete them if they were autogenerated and older than 4 weeks. - Adds --write-syncstreams option which defaults to tru

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/lock_game_logic into lp:widelands

2016-02-14 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/lock_game_logic into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/lock_game_logic/+merge/285980 -- Your team Widelands Developers is subscribed to br

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lock_game_logic into lp:widelands

2016-02-14 Thread GunChleoc
Sounds good to me :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/lock_game_logic/+merge/285980 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lock_game_logic. ___ Mailing list: https://lau

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lock_game_logic into lp:widelands

2016-02-14 Thread SirVer
I applied all code review comments now. Apparently, my analyze of the problem was either flawed or incomplete, since this has been reproduced again even with this patch. However, I still think it is useful to get this in, because the game logic should not depend on the refresh rate of the graph

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/opengl3 into lp:widelands

2016-02-14 Thread SirVer
I have confirmation that this patch does not fix any of the graphic glitches we saw so far on systems that have 3.2, so it seems like it is not useful to persue opengl 3 at this point in time. Retracting this merge request. -- https://code.launchpad.net/~widelands-dev/widelands/opengl3/+merge/

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/opengl3 into lp:widelands

2016-02-14 Thread SirVer
The proposal to merge lp:~widelands-dev/widelands/opengl3 into lp:widelands has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~widelands-dev/widelands/opengl3/+merge/285967 -- Your team Widelands Developers is requested to review the propos

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1544864 into lp:widelands

2016-02-14 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1544864 into lp:widelands. Commit message: Removed LuaBaseImmovable::get_size. The corresponding functions in LuaBuildingDescription and LuaImmovableDescription now return strings instead of ints for consistency and easier reading.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395278-network into lp:widelands

2016-02-14 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1395278-network into lp:widelands has been updated. Commit Message changed to: Refactored member variable names in src/network. For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-network/+merge/285990 --

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395278-network into lp:widelands

2016-02-14 Thread Klaus Halfmann
Klaus Halfmann has proposed merging lp:~widelands-dev/widelands/bug-1395278-network into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-network/+merge/285990 Make member variables lik

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/editor_help into lp:widelands

2016-02-14 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/editor_help into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/editor_help/+merge/283900 -- Your team Widelands Developers is subscribed to branch lp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/editor_help into lp:widelands

2016-02-14 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/editor_help/+merge/283900 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/editor_help. ___ Mailing list: https://launchpad.net/~widelands-dev Post

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lock_game_logic into lp:widelands

2016-02-14 Thread Klaus Halfmann
A test with TinoM palying on Impact with an AI, failed, going to reprodcu this -- https://code.launchpad.net/~widelands-dev/widelands/lock_game_logic/+merge/285980 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lock_game_logic.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/editor_help into lp:widelands

2016-02-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 686. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/109135916. Appveyor build 538. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_editor_help-

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/opengl3 into lp:widelands

2016-02-14 Thread GunChleoc
Now the glbinding variant - it will cause the texture bug with me that was only found on Windows before. The reason might again be my crappy graphics though, because the Windows build that Tino provided will also crash. I have known problems on both of my machines with some projects that use Ope

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lock_game_logic into lp:widelands

2016-02-14 Thread Klaus Halfmann
Hello SirVer: Id propose a small change, mostly comments only === modified file 'src/ui_basic/panel.cc' --- src/ui_basic/panel.cc 2016-02-13 19:17:06 + +++ src/ui_basic/panel.cc 2016-02-14 11:20:39 + @@ -148,9 +148,10 @@ // Panel-specific startup code. This might call

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/lock_game_logic into lp:widelands

2016-02-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 685. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/109052981. Appveyor build 537. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_lock_game_lo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lock_game_logic into lp:widelands

2016-02-14 Thread GunChleoc
This is how SirVer triggered the bug: run widelands with --maxfps=10 and host a game, run a second one with --maxfps=60 and join that game -> immediate desyncs. -- https://code.launchpad.net/~widelands-dev/widelands/lock_game_logic/+merge/285980 Your team Widelands Developers is subscribed to br

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lock_game_logic into lp:widelands

2016-02-14 Thread Klaus Halfmann
Hello Kaputtnick: I just review that code, you wrote: > Is there something specific to look at? I think we should do tests in the „real world“ with different FPS seconds and a real Network jitter. SirVers approach feels correct to me, but I am not sure is this may have adverse effects, as the g

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/map_hint_space into lp:widelands

2016-02-14 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/map_hint_space into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/map_hint_space/+merge/285407 -- Your team Widelands Developers is subscribed to bran

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lock_game_logic into lp:widelands

2016-02-14 Thread kaputtnik
Is there something specific to look at? I tested a short 2Player game against AI and found nothing strange. Does this affect calculation of statistics f.e. the productivity shown on each building? Is a game with 8 players better to test this changes? -- https://code.launchpad.net/~widelands-dev

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/map_hint_space into lp:widelands

2016-02-14 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/map_hint_space/+merge/285407 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/map_hint_space. ___ Mailing list: https://launchpad.net/~widelands-de

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/opengl3 into lp:widelands

2016-02-14 Thread GunChleoc
Now we run into trouble with my crappy graphics. I'll try a build with glbinding to check if it gets any better. Starting program: /home/bratzbert/sources/widelands/opengl3/widelands [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_d

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/zip_file_error_messages into lp:widelands

2016-02-14 Thread GunChleoc
You are right, that's a typo and needs to be a lowercase s. Looks like my compiler didn't care. I don't know how you can trigger the error message - I'd have to go through the code myself. The worst things that can happen with unicode filenames is that the path contains strange letters - I don

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lock_game_logic into lp:widelands

2016-02-14 Thread GunChleoc
Review: Approve code Not tested, but code LGTM. Maybe add a comment to the code to explain why we have the 2 separate intervals? -- https://code.launchpad.net/~widelands-dev/widelands/lock_game_logic/+merge/285980 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/wideland