Continuous integration builds have changed state:
Travis build 673. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/108855068.
Appveyor build 525. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1395278_
Is there really a need for a paragraph in map description? The place to show
the description is not really big, adding a possibility for a paragraph
consumes just more space. Is a normal line break also needed? I knew
king_of_nowhere has asked for this, but i think the description is meant to
h
Continuous integration builds have changed state:
Travis build 669. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/108740119.
Appveyor build 523. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_zip_file_err
Hello GunChleoc, I cared for the copyright.
For the type of the player_num / player_index we shoud use the type you
suggested, of course.
But this is
a) out of scope of the original bug.
b) I have no Idea what, especially in LUA, might break.-
We should delegate this to some other ticket.
BTW:
Code LGTM, but I have added some comments. Please have a look :)
Diff comments:
>
> === modified file 'src/scripting/lua_game.cc'
> --- src/scripting/lua_game.cc 2016-01-28 05:24:34 +
> +++ src/scripting/lua_game.cc 2016-02-12 17:03:35 +
> @@ -1132,19 +1132,19 @@
> };
>
> LuaMessage
Klaus Halfmann has proposed merging
lp:~widelands-dev/widelands/bug-1395278-scripting into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-scripting/+merge/285909
* Switch from m_ to _
Review: Approve testing
I tried French ad Cyrillic (i believe :-D ). I found long strings mostly in the
editor main menu and all looks fine for me.
--
https://code.launchpad.net/~widelands-dev/widelands/fit_button_text/+merge/285528
Your team Widelands Developers is subscribed to branch
lp:~wid
Mousewheel has been sort of broken since we moved to SDL2.
--
https://code.launchpad.net/~widelands-dev/widelands/editor_help/+merge/283900
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/editor_help.
___
Mailing list
Works :-)
One thing is curious: In "Terrains tab" either the up/down arrow keys are
working nor the mouse wheel in the left list. In "Trees tab" both are working
for the left list.
--
https://code.launchpad.net/~widelands-dev/widelands/editor_help/+merge/283900
Your team Widelands Developers is
Continuous integration builds have changed state:
Travis build 616. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/107568619.
Appveyor build 473. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_editor_help-4
This is ready for the next round now. I have made a separate commit for each
issue.
There are still some NOCOMs left that can either go or that I need some
information for.
--
https://code.launchpad.net/~widelands-dev/widelands/editor_help/+merge/283900
Your team Widelands Developers is subscri
Continuous integration builds have changed state:
Travis build 655. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/108128096.
Appveyor build 511. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fit_button_t
The proposal to merge lp:~widelands-dev/widelands/bug-1543944-suggested-teams
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1543944-suggested-teams/+merge/285654
--
Your team Widelands Develo
13 matches
Mail list logo
