[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1399621 into lp:widelands

The proposal to merge lp:~widelands-dev/widelands/bug-1399621 into lp:widelands has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1399621/+merge/258843 -- Your team Widelands Developers is requested to r

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/find_attack_soldiers into lp:widelands

We still have a reviewer saying "Needs fixing", which is why I didn't merge it yet. Let's wait for SirVer to get back. -- https://code.launchpad.net/~widelands-dev/widelands/find_attack_soldiers/+merge/245276 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/find

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1399621 into lp:widelands

Thanks for the review :) The extra checks were indeed nonsense, to I have removed them. I also added some space between rows, does this look OK now? I can't highlight only part of a string, because buttons don't allow richtext. Making only part of the string a button would make the click target

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1291904 into lp:widelands

Review: Needs Fixing When I tried to load saved network game from building_encyclopedia branch, it just crashed: Game: Reading Game Class Data ... GameLoader::load() took 1ms lastserial: 0 pure virtual method called terminate called without an active exception Program received signal SIGABRT, A