When I looked at this:
https://scan4.coverity.com/reports.htm#v12668/p10285/fileInstanceId=1968592&defectInstanceId=605921&mergedDefectId=64815
I found a peculiar thing. Compare lines 466 and 471 - how is it possible
that "_" is missing on line 466? In current trunk in both lines contains
"ware
Oh, I did not realize that this might be important, I will be more elaborate
next time
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1428396/+merge/256857
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1428396.
___
Hi, just a post-review comment:
Please write more descriptive commit messages when merging to trunk. This makes
it easier to tell what was changed, both when reading through the commit log,
but also when someone wants to know why a block of code was added six months
later.
Including the bug n
TiborB has proposed merging lp:~widelands-dev/widelands/bug-1442869 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1442869 in widelands: "Stopped production sites should produce something
from their consumed wares befor they stop"
https://bugs
The proposal to merge lp:~widelands-dev/widelands/bug-1428396 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1428396/+merge/256857
--
Your team Widelands Developers is subscribed to branch
lp
The proposal to merge lp:~widelands-dev/widelands/bug-1451078-fix into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1451078-fix/+merge/258118
--
Your team Widelands Developers is subscribed to br
Review: Approve
I don't know where I have my brain - of course the continue does do something
useful. Go ahead and merge. Thanks for the fix :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1451078-fix/+merge/258118
Your team Widelands Developers is subscribed to branch
lp:~widelan
Review: Approve
Makes sense to me. Go ahead and merge :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1428396/+merge/256857
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1428396.
___
Mailing list:
I was worried that fully trained soldiers would get stuck in the trainingsite
now. I have tested and dug around in the code, and there is a separate function
"drop_unupgradable_soldiers" that takes care of that.
So, please ignore my last suggestion. Instead, we can remove the "if (level >
upgra
The proposal to merge lp:~widelands-dev/widelands/bug-1451069 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1451069/+merge/258119
--
Your team Widelands Developers is subscribed to branch
lp
10 matches
Mail list logo
