Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1380287 into lp:widelands

2015-04-07 Thread TiborB
comments fixed, I rerun the regression test (all OK) and merged it to trunk -- https://code.launchpad.net/~widelands-dev/widelands/bug-1380287/+merge/252507 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1380287. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1380287 into lp:widelands

2015-04-07 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1380287 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1380287/+merge/252507 -- Your team Widelands Developers is subscribed to branch lp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1380287 into lp:widelands

2015-04-07 Thread SirVer
Review: Needs Fixing I found a couple more nits. Otherwise LGTM, please merge after fixing them. Diff comments: > === modified file 'src/ai/ai_help_structs.h' > --- src/ai/ai_help_structs.h 2015-03-26 06:59:37 + > +++ src/ai/ai_help_structs.h 2015-04-07 13:33:49 + > @@ -438,7 +438,7 @@

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1380287 into lp:widelands

2015-04-07 Thread GunChleoc
Review: Approve I refactored the enums, made the status function return strings, and added some tests. Please review my code before merging. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1380287/+merge/252507 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/