Review: Needs Fixing
Couple of comments in the code. Only small things.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1341079/+merge/227441
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1341079.
__
I am very meh about the 'unknowns'. If somebody has a script, let's do it.
Otherwise we'll keep this as legacy.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1341674/+merge/227693
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands
The aim should be to get this (and my branch) merged into trunk ASAP and then
branch again to tackle the remaining issues. Smaller branches are much easier
to work with anyways.
I try to look into this in more detail on the weekend.
--
https://code.launchpad.net/~widelands-dev/widelands/fh1/+me
The proposal to merge lp:~widelands-dev/widelands/bug-999262_part2 into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-999262_part2/+merge/227348
--
https://code.launchpad.net/~widelands-dev/widela
Review: Approve
looks good.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-999262_part2/+merge/227348
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-999262_part2.
___
Mailing list: https://launchpad.
The proposal to merge lp:~widelands-dev/widelands/furnace into lp:widelands has
been updated.
Description changed to:
As discussed on IRC earlier today, unify the charcoal burner/burner's house and
rename it to Charcoal Furnace.
Updated:
- tribes: images, names and conf
- campaigns: references
Hans Joachim Desserud has proposed merging lp:~widelands-dev/widelands/furnace
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
As discussed on IRC earlier today, unify t
Review: Needs Fixing
1) Is strange, but makes sense. I do not fully understand why that is needed
now and wasn't before, but meh.
2) Dangerous assumption. The speed of a dynamic_cast() depends hugely on many
factors. String comparison is always slow. See
http://stackoverflow.com/questions/9778
Review: Resubmit
This is ready for review again.
2 things I'd like to point out:
1. I had to change the visibility of a class member for the code to compile -
check the NOCOM here:
http://bazaar.launchpad.net/~widelands-dev/widelands/bug-1341081/revision/7113#src/logic/carrier.h
Since it'S st
I have completely shifted the definition of the notification from worker to
productionsite.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-999262_part2/+merge/227348
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-999262_part2.
Unless someone can come up with a smart shell script that puts bzr blame and
codecheck together, a lot of work.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1341674/+merge/227693
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands
With bzr blame , you can see for every line who changed it last. I do not
know how much work that is, but it would help to avoid so many "unknown"s.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1341674/+merge/227693
Your team Widelands Developers is requested to review the proposed
I will try to tidy the patch.
As we should first converge the API in graphics/ and text_layout.h, maybe you
should have a look there in the first place. From what I see, your text_layout
looks more appealing. I think we should merge yours into this one and update
text_layout and text_area.
Thi
13 matches
Mail list logo
