Yeah. I don't see why we should back port it at this time. It's an API
improvement, but not a life saver.
Eelco
On 8/21/06, Frank Bille <[EMAIL PROTECTED]> wrote:
> I haven't done that. I could try that tonight and then backport it. But I
> have the same thought. I'm not sure it should be backpor
I haven't done that = I haven't tried it.On 8/21/06, Frank Bille <[EMAIL PROTECTED]> wrote:
I haven't done that. I could try that tonight and then backport it. But I have the same thought. I'm not sure it should be backported to
1.2. Right now it's only in 2.x- Frank
On 8/21/06, Martijn Dashorst <
I haven't done that. I could try that tonight and then backport it. But I have the same thought. I'm not sure it should be backported to 1.2. Right now it's only in 2.x- Frank
On 8/21/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote:
Have you tested it as a drop-in replacement for wicket-1.2.1 (or 1.
Have you tested it as a drop-in replacement for wicket-1.2.1 (or 1.2)
? Binary compatibility is still something we should strive for. Is it
possible that with this change the binary compatibility has been
altered?
Perhaps someone *expecting* that component instanceof Button returns
false for AjaxS
Committed yesterday. On 8/19/06, Frank Bille <[EMAIL PROTECTED]> wrote:
On 8/19/06, Matej Knopp <[EMAIL PROTECTED]> wrote:
So? What's the progress with this? Looking at current AjaxSubmitLink itstill extends WebMarkupContainer...Yeah I know.. thanx bad conscience :)(I'm almost done, just need a li
On 8/19/06, Matej Knopp <[EMAIL PROTECTED]> wrote:
So? What's the progress with this? Looking at current AjaxSubmitLink itstill extends WebMarkupContainer...Yeah I know.. thanx bad conscience :)(I'm almost done, just need a little test and to commit it)
- Frank
So? What's the progress with this? Looking at current AjaxSubmitLink it
still extends WebMarkupContainer...
-Matej
Frank Bille wrote:
> Yup that was the idea ;). Ok anyone else have an opinion?
>
> I still don't see this as an API break. I'll backport it as well.
>
> Frank
>
> On 8/11/06, * J
With Johan's remarks... sounds good.
Eelco
On 8/11/06, Frank Bille <[EMAIL PROTECTED]> wrote:
> Yup that was the idea ;). Ok anyone else have an opinion?
>
> I still don't see this as an API break. I'll backport it as well.
>
>
> Frank
>
> On 8/11/06, Johan Compagner <[EMAIL PROTECTED]> wrote:
>
Yup that was the idea ;). Ok anyone else have an opinion?I still don't see this as an API break. I'll backport it as well.FrankOn 8/11/06,
Johan Compagner <[EMAIL PROTECTED]> wrote:
fine by me then you can move Form instance to the button class and introduce the form param constructors also there.
fine by me then you can move Form instance to the button class and introduce the form param constructors also there.SubmitLink can be both.. It can be build on a button (generate onclick) But you don't have to introduce anything special because this line:
button = (Button)getPage().visitChildren(Su
Good point. But then Button really needs to be able to submit a form which it's not part of. Else we will have to introduce AjaxSubmitLink in Form.findSubmittingButton. FrankOn 8/11/06,
Johan Compagner <[EMAIL PROTECTED]> wrote:
Why would AjaxSubmitLink extends SubmitLink?I get the name part that
Why would AjaxSubmitLink extends SubmitLink?I get the name part that it seems that wayBut purely functional so code reuse it is as far as i see nothingBecause what SubmitLink does on onComponentTag:tag.put("onclick", getTriggerJavaScript());
is really not needed or wanted for the AjaxSubmitLink..Be
And by the way it was no big deal extended SubmitLink and Button. It "almost" worked without any changes. :)FrankOn 8/11/06, Frank Bille
<[EMAIL PROTECTED]> wrote:
HeyI have changed AjaxSubmitLink and AjaxSubmitButton to extend SubmitLink and Button (not committed yet). This gives us the plessure
HeyI have changed AjaxSubmitLink and AjaxSubmitButton to extend SubmitLink and Button (not committed yet). This gives us the plessure of having setDefaultFormProcessing on the AjaxSubmit*.I have to "issues" that I would like your oppinions on:
AjaxSubmitLink, SubmitLink AND AjaxSubmitButton can all
14 matches
Mail list logo
