Re: [web2py] Re: testing Recaptcha failed on bizzard error

2016-04-06 Thread Richard Vézina
I take note... As I said it a draft... I consider having something even not perfect is better than non and we have to start somewhere... I learn a lot about web2py internal these days and I have a very limited time... I bang my head on all sort of issue trying to create these tests so don't have ti

Re: [web2py] Re: testing Recaptcha failed on bizzard error

2016-04-06 Thread Niphlod
don't get it in the wrong way, but covering how a recaptcha is serialized serves noone. If one uses recaptcha and he doesn't get the same number of spaces between (s) a failing test identifying that there are 2 instead of 3 spaces doesn't get web2py more covered (even if machines tell you so).

Re: [web2py] Re: testing Recaptcha failed on bizzard error

2016-04-06 Thread Richard Vézina
I try to create self.request and if I remember it start throwing error about threading... I know they are really basic test and the only objective was to get some coverage, start testing and see the difficulty it represents... Richard On Wed, Apr 6, 2016 at 2:49 PM, Niphlod wrote: > that test

Re: [web2py] Re: testing Recaptcha failed on bizzard error

2016-04-06 Thread Niphlod
that test doesn't really assure recaptcha will ever work and it's completely bogus: it just tries to enforce that serialization will work exatcly as it is now. the real issue is that there isn't a request anywhere On Wednesday, April 6, 2016 at 8:33:47 PM UTC+2, Richard wrote: > > it failed for

Re: [web2py] Re: testing Recaptcha failed on bizzard error

2016-04-06 Thread Richard Vézina
it failed for the same reason On Wed, Apr 6, 2016 at 2:29 PM, Niphlod wrote: > recaptcha should be discarded and recaptcha2 should be promoted as the > default. > > > On Wednesday, April 6, 2016 at 6:17:38 PM UTC+2, Richard wrote: >> >> Hello, >> >> https://github.com/web2py/web2py/blob/master/g

[web2py] Re: testing Recaptcha failed on bizzard error

2016-04-06 Thread Niphlod
recaptcha should be discarded and recaptcha2 should be promoted as the default. On Wednesday, April 6, 2016 at 6:17:38 PM UTC+2, Richard wrote: > > Hello, > > https://github.com/web2py/web2py/blob/master/gluon/tools.py#L848 > > request = request or current.request > self.request_v