Re: [web2py] Re: Bug and fix about IS_DATE_IN_RANGE()

2010-05-08 Thread Jonathan Lundell
On May 8, 2010, at 12:52 AM, Iceberg wrote: > Thanks for the quick response and fix. But one more comment when > talking about doctest. You current doctest cases does not qualified to > catch the bug. You need to design cases for critical point. Besides, > you need not use "print" in doctest. Rig

[web2py] Re: Bug and fix about IS_DATE_IN_RANGE()

2010-05-08 Thread Iceberg
Thanks for the quick response and fix. But one more comment when talking about doctest. You current doctest cases does not qualified to catch the bug. You need to design cases for critical point. Besides, you need not use "print" in doctest. For example, the current trunk: >>> v = IS_DATE

Re: [web2py] Re: Bug and fix about IS_DATE_IN_RANGE()

2010-05-07 Thread Jonathan Lundell
On May 7, 2010, at 4:39 PM, mdipierro wrote: > Done. I added one test each. we should have more tests in gluon/tests > we have none, only doctests for validators. Yes, we should (though doctests are nice documentation for validators). There's a plugin for nose that will run doctests along with u

[web2py] Re: Bug and fix about IS_DATE_IN_RANGE()

2010-05-07 Thread mdipierro
Done. I added one test each. we should have more tests in gluon/tests we have none, only doctests for validators. On May 7, 4:26 pm, Jonathan Lundell wrote: > On May 7, 2010, at 9:30 AM, Iceberg wrote: > > > Right now, IS_DATE_IN_RANGE(minimum=foo, maximum=bar) does NOT accept > > the given minim

[web2py] Re: Bug and fix about IS_DATE_IN_RANGE()

2010-05-07 Thread mdipierro
oops. WIll fix this tonight On May 7, 11:30 am, Iceberg wrote: > Hi Massimo, > > Right now, IS_DATE_IN_RANGE(minimum=foo, maximum=bar) does NOT accept > the given minimum nor maximum value. That is not the design intention > according to error message. Please get rid off the two equal marks in >