GitHub user vega113 opened a pull request:
https://github.com/apache/incubator-wave/pull/14
Updates to use jetty 9.2.14
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vega113/incubator-wave
feature/update-jetty-version-to-9-2
GitHub user vega113 opened a pull request:
https://github.com/apache/incubator-wave/pull/15
WAVE-438 - Removes XMPP federation implementation along with relevantâ¦
⦠resources and unit tests.
Fixes issue with a test when running with Java1.8.
You can merge this pull
GitHub user vega113 opened a pull request:
https://github.com/apache/incubator-wave/pull/16
WAVE-439 - Changes source compatibility to Java1.8 and fixes weird isâ¦
â¦sues with code that 1.8 was not backward compatible.
Some of the issues were resolved by updating to newer
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/19#discussion_r106804336
--- Diff:
wave/src/main/java/org/apache/wave/box/server/rpc/InitialsAvatarsServlet.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/19#discussion_r106805040
--- Diff: wave/dist/run-server.bat ---
@@ -1,23 +0,0 @@
-echo off
--- End diff --
It would be great if we could update the run
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/19#discussion_r106786459
--- Diff:
wave/src/main/java/org/apache/wave/box/server/rpc/InitialsAvatarsServlet.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache
GitHub user vega113 opened a pull request:
https://github.com/apache/incubator-wave/pull/20
WAVE-440 - updates oauth jars version and adds Atlassian repo.
This should fix the issue with missing oauth-consumer.jar.
I compiled and ran the unit tests.
You can merge this pull
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/21#discussion_r111780378
--- Diff:
wave/src/main/java/org/apache/wave/box/server/rpc/InitialsAvatarsServlet.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/21#discussion_r111781019
--- Diff:
wave/src/main/java/org/waveprotocol/wave/client/common/util/SignalEventImpl.java
---
@@ -93,8 +93,8 @@ public static boolean isKeyEvent
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/21#discussion_r111781203
--- Diff:
wave/src/main/java/org/apache/wave/box/server/rpc/InitialsAvatarsServlet.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/21#discussion_r111923579
--- Diff:
wave/src/main/java/org/apache/wave/box/server/rpc/InitialsAvatarsServlet.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/22#discussion_r112370672
--- Diff: helper/style/style.go ---
@@ -0,0 +1,91 @@
+//
--- End diff --
I would prefer to have a Gradle task for checking style
Github user vega113 commented on the issue:
https://github.com/apache/incubator-wave/pull/22
Can't we create our own checkstyle.xml instead of using google_style.xml?
Also, it seems like we already have jacoco plugin.
---
If your project is set up for it, you can reply to
Github user vega113 commented on the issue:
https://github.com/apache/incubator-wave/pull/22
Are you sure we can't use the checkstyle with google_style? I think as long
as this is not part of shipped binaries - we can use it.
---
If your project is set up for it, you can rep
Github user vega113 commented on the issue:
https://github.com/apache/incubator-wave/pull/22
Anyway, I am fine with your commit. We can add gradle plugin later and use
both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user vega113 commented on the issue:
https://github.com/apache/incubator-wave/pull/21
I guess you could rebase your branch instead of opening a new one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vega113 commented on the issue:
https://github.com/apache/incubator-wave/pull/22
I guess we will need to relax a bit the rules, as there's too many style
issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user vega113 commented on the issue:
https://github.com/apache/incubator-wave/pull/19
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/24#discussion_r114601665
--- Diff:
wave/src/main/java/org/waveprotocol/box/server/frontend/WaveViewSubscription.java
---
@@ -154,7 +155,15 @@ public synchronized void
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/24#discussion_r114613617
--- Diff:
wave/src/main/java/org/waveprotocol/box/server/frontend/WaveViewSubscription.java
---
@@ -154,7 +155,15 @@ public synchronized void
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/24#discussion_r114602007
--- Diff:
wave/src/main/java/org/waveprotocol/box/server/frontend/WaveViewSubscription.java
---
@@ -154,7 +155,15 @@ public synchronized void
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/24#discussion_r114750100
--- Diff:
wave/src/main/java/org/waveprotocol/box/server/frontend/WaveViewSubscription.java
---
@@ -154,7 +155,15 @@ public synchronized void
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/25#discussion_r115307098
--- Diff: pst/src/main/proto/google/protobuf/descriptor.proto ---
@@ -37,10 +37,14 @@
// without any other information (e.g. without reading its
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/25#discussion_r115306212
--- Diff: pst/src/main/proto/google/protobuf/descriptor.proto ---
@@ -37,10 +37,14 @@
// without any other information (e.g. without reading its
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/24#discussion_r118841143
--- Diff:
wave/src/main/java/org/waveprotocol/box/server/frontend/WaveViewSubscription.java
---
@@ -154,7 +155,15 @@ public synchronized void
Github user vega113 commented on the issue:
https://github.com/apache/incubator-wave/pull/24
I didn't test the last commit nut it LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vega113 commented on the issue:
https://github.com/apache/incubator-wave/pull/27
Great changes in general, however:
- We need to try and maximize the vertical screen space to allow more space
for the UI.
- I would like to retain the red/green color on the status
27 matches
Mail list logo
