Thanks Adam, lets include your text in the report.
One thing, regarding the editor the issue caused by chrome 54 has been fixed in
swellrt... I will send a PR ;)
El 5 dic. 2016 16:48, Adam John escribió:
Excellent work, Pablo & folks. I took what both of you wrote and combined
/ formatted..
my own fix is in the dependencies fix branch if you wanna cross check them,
though mine is more of a hot fix.
On Tue, 6 Dec 2016 at 19:05 wrote:
> Thanks Adam, lets include your text in the report.
>
> One thing, regarding the editor the issue caused by chrome 54 has been
> fixed in swellrt... I
GitHub user pablojan opened a pull request:
https://github.com/apache/incubator-wave/pull/18
Fixes taken from SwellRT
This PR contains some bug fixes taken from SwellRT fork.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pabloja
Evan, I checked out your hot fix, so hot indeed :D I sent a pull PR with my
version.
2016-12-06 10:23 GMT+01:00 Evan Hughes :
> my own fix is in the dependencies fix branch if you wanna cross check them,
> though mine is more of a hot fix.
>
> On Tue, 6 Dec 2016 at 19:05 wrote:
>
> > Thanks Adam
Finally I've written down a shorter version of Adam's text following
Upayavira suggestion.
https://wiki.apache.org/incubator/December2016
Also I pointed out some items I am not sure how to fill, I guess @upayavira
you should double check!
2016-12-06 12:49 GMT+01:00 Pablo Ojanguren :
> Evan, I
Ill review the pull requests in the morn, technically i see nothing wrong
with my fix :P the code shared between the webkit and firefox are very
similar :P. Much appreciated specially with the dev server. Has swellrt
been doing many tests with GWt, we did manage to get ours working, just a
few comp
:D I meant your fix doesn't look into the source of the bug, so it could
cause collateral effects. Anyway, it opens a debate about which logic from
editor could be removed as far as modern browsers have changed a lot.
About GWT tests, we have avoided them because we avoid GWT specific code in
mos
