Re: Client-Server Protocol

2014-01-15 Thread Andrew Kaplanov
Wiab cliet-server protocol is not corresponded to specification in http://www.waveprotocol.org/protocol/design-proposals/clientserver-protocol. It is specified in src/org/waveprotocol/box/common/comms/waveclient-rpc.proto in the distribtive. Wiab.pro released http://www.waveprotocol.org/protocol/de

Re: Review Request 16751: MongoDB store for deltas

2014-01-15 Thread Pablo Ojanguren
> On Jan. 14, 2014, 6:16 p.m., Yuri Zelikov wrote: > > I have an issue with binary patches, can you maybe create a pull request > > for https://github.com/apache/incubator-wave? Sure, I've created a pull request... https://github.com/apache/incubator-wave/pull/2 - Pablo ---

Re: Code reviews app

2014-01-15 Thread Yuri Z
Judging by the comments in the issue, it doesn't look like Gerrit is a real option. Anyway, I left a comment there with the question. On Mon, Jan 13, 2014 at 6:33 PM, Ryan Hill wrote: > +1 for Gerrit > > > On Mon, Jan 13, 2014 at 3:35 AM, Thomas Broyer wrote: > > > On Sun, Jan 12, 2014 at 5:14

Re: Code reviews app

2014-01-15 Thread Yuri Z
Got a really fast reply from Infra - Gerrit is not an option. I am not sure whether GitHub pull requests are fine with Apache, maybe mentors can help here? But from the technical point of view - GitHub PR are a lot easier to work with. Checking a patch can be done with single Git command, instead o