Re: Code reviews app

2014-01-13 Thread Bruno Gonzalez (aka stenyak)
On 2014-01-12 17:14, Yuri Z wrote: Until now we used ReviewBoard for code reviews. It's a powerful app and it served us well, but it seems like there are a few pros and cons. As we recently moved to Git, we have a new option - we can use the GitHub forks - https://github.com/apache/incubator-w

Re: Code reviews app

2014-01-13 Thread Thomas Broyer
On Sun, Jan 12, 2014 at 5:14 PM, Yuri Z wrote: > Hi > Until now we used ReviewBoard for code reviews. It's a powerful app and it > served us well, but it seems like there are a few pros and cons. > As we recently moved to Git, we have a new option - we can use the GitHub > forks - https://github.

Re: Review Request 16751: MongoDB store for deltas

2014-01-13 Thread Pablo Ojanguren
> On Jan. 12, 2014, 7:35 p.m., Andrew Kaplanov wrote: > > src/org/waveprotocol/box/server/persistence/mongodb/MongoDbDeltaCollection.java, > > line 81 > > > > > > This query can be created only one time. Methods calli

Re: Review Request 16751: MongoDB store for deltas

2014-01-13 Thread Andrew Kaplanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16751/#review31610 --- src/org/waveprotocol/box/server/persistence/mongodb/MongoDbDeltaCol

Re: Review Request 16751: MongoDB store for deltas

2014-01-13 Thread Pablo Ojanguren
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16751/ --- (Updated Jan. 13, 2014, 3:07 p.m.) Review request for wave. Changes ---

Re: Code reviews app

2014-01-13 Thread Ryan Hill
+1 for Gerrit On Mon, Jan 13, 2014 at 3:35 AM, Thomas Broyer wrote: > On Sun, Jan 12, 2014 at 5:14 PM, Yuri Z wrote: > > > Hi > > Until now we used ReviewBoard for code reviews. It's a powerful app and > it > > served us well, but it seems like there are a few pros and cons. > > As we recently