Re: Review Request: Export and Import.

> On Dec. 1, 2012, 3:26 p.m., Yuri Zelikov wrote: > > LGTM > > Committed as r1416008 > > Yuri Zelikov wrote: > Please close the review request > > Andrew Kaplanov wrote: > Please remove obsolete file > test/org/waveprotocol/box/server/waveserver/ImportServletTest.java > > Andrew Kapla

Re: Review Request: Export and Import.

> On Dec. 1, 2012, 3:26 p.m., Yuri Zelikov wrote: > > LGTM > > Committed as r1416008 > > Yuri Zelikov wrote: > Please close the review request > > Andrew Kaplanov wrote: > Please remove obsolete file > test/org/waveprotocol/box/server/waveserver/ImportServletTest.java > > Andrew Kapla

Re: Review Request: Export and Import.

> On Dec. 1, 2012, 3:26 p.m., Yuri Zelikov wrote: > > LGTM > > Committed as r1416008 > > Yuri Zelikov wrote: > Please close the review request > > Andrew Kaplanov wrote: > Please remove obsolete file > test/org/waveprotocol/box/server/waveserver/ImportServletTest.java It is marked as

Re: Review Request: Export and Import.

> On Dec. 1, 2012, 3:26 p.m., Yuri Zelikov wrote: > > LGTM > > Committed as r1416008 > > Yuri Zelikov wrote: > Please close the review request Please remove obsolete file test/org/waveprotocol/box/server/waveserver/ImportServletTest.java - Andrew ---

Re: Review Request: Export and Import.

> On Dec. 1, 2012, 3:26 p.m., Yuri Zelikov wrote: > > LGTM > > Committed as r1416008 Please close the review request - Yuri --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7958/#review13935 -

Re: Review Request: Export and Import.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7958/#review13935 --- Ship it! LGTM Committed as r1416008 - Yuri Zelikov On Nov. 26, 20

Re: Review Request: Export and Import.

> On Dec. 1, 2012, 12:40 p.m., Yuri Zelikov wrote: > > I can't apply the last version of the patch. Seems like the diff was > > created from modified sources. > > Actually it was my source out of sync, so never mind. - Yuri --- This is

Re: Review Request: Export and Import.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7958/#review13930 --- I can't apply the last version of the patch. Seems like the diff was

Re: Review Request: Export and Import.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7958/ --- (Updated Nov. 26, 2012, 11:44 a.m.) Review request for wave and Yuri Zelikov.

Re: Review Request: Export and Import.

> On Nov. 17, 2012, 11:01 a.m., Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/expimp/DomainConverter.java, line 132 > > > > > > Can we extract the address part without parsing the participantId? > > Like Partic

Re: Review Request: Export and Import.

> On Nov. 17, 2012, 11:01 a.m., Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/server/robots/OperationContextImpl.java, line 388 > > > > > > Why null and not "ImmutableList.of();" > > Andrew Kaplanov wrote: > T

Re: Review Request: Export and Import.

> On Nov. 17, 2012, 11:01 a.m., Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/expimp/DomainConverter.java, line 132 > > > > > > Can we extract the address part without parsing the participantId? > > Like Partic

Re: Review Request: Export and Import.

> On Nov. 17, 2012, 11:01 a.m., Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/expimp/DomainConverter.java, line 132 > > > > > > Can we extract the address part without parsing the participantId? > > Like Partic

Re: Review Request: Export and Import.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7958/ --- (Updated Nov. 25, 2012, 7:12 p.m.) Review request for wave and Yuri Zelikov. C

Re: Review Request: Export and Import.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7958/#review13539 --- Some more comments. Andrew, the patch is really big one! I really app

Re: Review Request: Export and Import.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7958/ --- (Updated Nov. 12, 2012, 9:26 a.m.) Review request for wave and Yuri Zelikov. C

Re: Review Request: Export and Import.

> On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/com/google/wave/api/WaveService.java, line 89 > > > > > > Why use this additional field? > > Andrew Kaplanov wrote: > To can redefine default timeout valu

Re: Review Request: Export and Import.

> On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/com/google/wave/api/WaveService.java, line 89 > > > > > > Why use this additional field? > > Andrew Kaplanov wrote: > To can redefine default timeout valu

Re: Review Request: Export and Import.

> On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/com/google/wave/api/WaveService.java, line 89 > > > > > > Why use this additional field? > > Andrew Kaplanov wrote: > To can redefine default timeout valu

Re: Review Request: Export and Import.

> On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/com/google/wave/api/WaveService.java, line 89 > > > > > > Why use this additional field? > > Andrew Kaplanov wrote: > To can redefine default timeout valu

Re: Review Request: Export and Import.

> On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/com/google/wave/api/WaveService.java, line 89 > > > > > > Why use this additional field? > > Andrew Kaplanov wrote: > To can redefine default timeout valu

Re: Review Request: Export and Import.

> On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/com/google/wave/api/WaveService.java, line 89 > > > > > > Why use this additional field? > > Andrew Kaplanov wrote: > To can redefine default timeout valu

Re: Review Request: Export and Import.

> On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/com/google/wave/api/WaveService.java, line 89 > > > > > > Why use this additional field? > > Andrew Kaplanov wrote: > To can redefine default timeout valu

Re: Review Request: Export and Import.

> On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/com/google/wave/api/WaveService.java, line 89 > > > > > > Why use this additional field? > > Andrew Kaplanov wrote: > To can redefine default timeout valu

Re: Review Request: Export and Import.

> On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/com/google/wave/api/WaveService.java, line 89 > > > > > > Why use this additional field? > > Andrew Kaplanov wrote: > To can redefine default timeout valu

Re: Review Request: Export and Import.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7958/ --- (Updated Nov. 10, 2012, 8:18 p.m.) Review request for wave and Yuri Zelikov. C

Re: Review Request: Export and Import.

> On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > Some initial comments. > > Regarding the google client jars - i think there's no need to add them as > > WIAB already has them. Google client jars are removed as unused. > On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/com/goo

Re: Review Request: Export and Import.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7958/#review13289 --- Some initial comments. Regarding the google client jars - i think the

Re: Review Request: Export and Import.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7958/#review13243 --- Thanks for the patch! I ll try to review ASAP. - Yuri Zelikov On N

Review Request: Export and Import.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7958/ --- Review request for wave and Yuri Zelikov. Description --- Export/Import cli