Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-06-14 Thread Vicente J. Ruiz Jurado
> On March 21, 2013, 2:05 p.m., Ali Lown wrote: > > Tested locally and seems to work as expected. > > > > Code is fine, allows extending to more complex colour pickers in future if > > needed. (Though not sure if this is really necessary). > > Vicente J. Ruiz Jurado wrote: > Another simple

Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-06-08 Thread Yuri Zelikov
> On March 21, 2013, 2:05 p.m., Ali Lown wrote: > > Tested locally and seems to work as expected. > > > > Code is fine, allows extending to more complex colour pickers in future if > > needed. (Though not sure if this is really necessary). > > Vicente J. Ruiz Jurado wrote: > Another simple

Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-06-08 Thread Ali Lown
> On March 21, 2013, 2:05 p.m., Ali Lown wrote: > > Tested locally and seems to work as expected. > > > > Code is fine, allows extending to more complex colour pickers in future if > > needed. (Though not sure if this is really necessary). > > Vicente J. Ruiz Jurado wrote: > Another simple

Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-06-08 Thread Yuri Zelikov
> On March 21, 2013, 2:05 p.m., Ali Lown wrote: > > Tested locally and seems to work as expected. > > > > Code is fine, allows extending to more complex colour pickers in future if > > needed. (Though not sure if this is really necessary). > > Vicente J. Ruiz Jurado wrote: > Another simple

Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-06-08 Thread Ali Lown
> On March 21, 2013, 2:05 p.m., Ali Lown wrote: > > Tested locally and seems to work as expected. > > > > Code is fine, allows extending to more complex colour pickers in future if > > needed. (Though not sure if this is really necessary). > > Vicente J. Ruiz Jurado wrote: > Another simple

Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-04-15 Thread Vicente J. Ruiz Jurado
> On March 21, 2013, 2:05 p.m., Ali Lown wrote: > > Tested locally and seems to work as expected. > > > > Code is fine, allows extending to more complex colour pickers in future if > > needed. (Though not sure if this is really necessary). > > Vicente J. Ruiz Jurado wrote: > Another simple

Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-04-07 Thread Yuri Zelikov
> On March 21, 2013, 2:05 p.m., Ali Lown wrote: > > Tested locally and seems to work as expected. > > > > Code is fine, allows extending to more complex colour pickers in future if > > needed. (Though not sure if this is really necessary). > > Vicente J. Ruiz Jurado wrote: > Another simple

Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-04-06 Thread Vicente J. Ruiz Jurado
> On March 21, 2013, 2:05 p.m., Ali Lown wrote: > > Tested locally and seems to work as expected. > > > > Code is fine, allows extending to more complex colour pickers in future if > > needed. (Though not sure if this is really necessary). > > Vicente J. Ruiz Jurado wrote: > Another simple

Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-04-05 Thread Yuri Zelikov
> On March 21, 2013, 2:05 p.m., Ali Lown wrote: > > Tested locally and seems to work as expected. > > > > Code is fine, allows extending to more complex colour pickers in future if > > needed. (Though not sure if this is really necessary). > > Vicente J. Ruiz Jurado wrote: > Another simple

Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-04-04 Thread Yuri Zelikov
> On March 21, 2013, 2:05 p.m., Ali Lown wrote: > > Tested locally and seems to work as expected. > > > > Code is fine, allows extending to more complex colour pickers in future if > > needed. (Though not sure if this is really necessary). > > Vicente J. Ruiz Jurado wrote: > Another simple

Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-04-01 Thread Ali Lown
> On March 21, 2013, 2:05 p.m., Ali Lown wrote: > > Tested locally and seems to work as expected. > > > > Code is fine, allows extending to more complex colour pickers in future if > > needed. (Though not sure if this is really necessary). > > Vicente J. Ruiz Jurado wrote: > Another simple

Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-04-01 Thread Vicente J. Ruiz Jurado
> On March 21, 2013, 2:05 p.m., Ali Lown wrote: > > Tested locally and seems to work as expected. > > > > Code is fine, allows extending to more complex colour pickers in future if > > needed. (Though not sure if this is really necessary). Another simple color picker that I want to develop is

Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-03-21 Thread Ali Lown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9841/#review18206 --- Ship it! Tested locally and seems to work as expected. Code is fine

Re: Review Request: Add color and backcolor buttons to edit toolbar

2013-03-11 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9841/ --- (Updated March 11, 2013, 12:13 p.m.) Review request for wave, Michael MacFadden,

Review Request: Add color and backcolor buttons to edit toolbar

2013-03-10 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9841/ --- Review request for wave, Michael MacFadden, Yuri Zelikov, Ali Lown, and hegsie.