Re: Review Request: Attachments.

2012-11-17 Thread Yuri Zelikov
> On Nov. 1, 2012, 8:15 p.m., Yuri Zelikov wrote: > > Ship It! Andrew, please close the review request - Yuri --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/#review13007 ---

Re: Review Request: Attachments.

2012-11-01 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/#review13007 --- Ship it! Ship It! - Yuri Zelikov On Oct. 22, 2012, 9:05 a.m., And

Re: Review Request: Attachments.

2012-11-01 Thread Yuri Zelikov
> On Nov. 1, 2012, 12:53 p.m., Yuri Zelikov wrote: > > ./server-config.xml, line 112 > > > > > > No token for "thumbnail_patterns_directory"? It should be also added to > > server.config.example file. I fixed it by my

Re: Review Request: Attachments.

2012-11-01 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/#review12993 --- Regarding the icons - can we maybe just put them into a non configura

Re: Review Request: Attachments.

2012-10-22 Thread Andrew Kaplanov
> On Oct. 21, 2012, 4:36 p.m., Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/server/persistence/file/FileAttachmentStore.java, > > line 131 > > > > > > proto.getPB() -> Can we rename getPB() method into something

Re: Review Request: Attachments.

2012-10-22 Thread Andrew Kaplanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/ --- (Updated Oct. 22, 2012, 9:05 a.m.) Review request for wave and Yuri Zelikov. C

Re: Review Request: Attachments.

2012-10-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/#review12633 --- Great job! I tested it and it works fine - just minor comments. ./s

Re: Review Request: Attachments.

2012-10-17 Thread Andrew Kaplanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/ --- (Updated Oct. 17, 2012, 11:55 a.m.) Review request for wave and Yuri Zelikov.

Re: Review Request: Attachments.

2012-10-12 Thread Andrew Kaplanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/ --- (Updated Oct. 12, 2012, 10:26 a.m.) Review request for wave and Yuri Zelikov.

Re: Review Request: Attachments.

2012-10-12 Thread Andrew Kaplanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/ --- (Updated Oct. 12, 2012, 9:52 a.m.) Review request for wave and Yuri Zelikov. C

Re: Review Request: Attachments.

2012-10-12 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/#review12395 --- Hi Andrew. Can you please attach the binary files to the patch? -

Re: Review Request: Attachments.

2012-10-10 Thread Andrew Kaplanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/ --- (Updated Oct. 10, 2012, 10:04 a.m.) Review request for wave and Yuri Zelikov.

Re: Review Request: Attachments.

2012-10-10 Thread Yuri Zelikov
> On Oct. 9, 2012, 7:38 p.m., Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/server/persistence/mongodb/MongoDbStore.java, > > line 187 > > > > > > I think the original idea of including the waveletName in the comp

Re: Review Request: Attachments.

2012-10-10 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/#review12311 --- ./src/org/waveprotocol/box/server/attachment/AttachmentService.java

Re: Review Request: Attachments.

2012-10-10 Thread Andrew Kaplanov
> On Oct. 9, 2012, 7:38 p.m., Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/server/persistence/mongodb/MongoDbStore.java, > > line 187 > > > > > > I think the original idea of including the waveletName in the comp

Re: Review Request: Attachments.

2012-10-10 Thread Andrew Kaplanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/ --- (Updated Oct. 10, 2012, 8:13 a.m.) Review request for wave and Yuri Zelikov. C

Re: Review Request: Attachments.

2012-10-10 Thread Andrew Kaplanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/ --- (Updated Oct. 10, 2012, 7:46 a.m.) Review request for wave and Yuri Zelikov. C

Re: Review Request: Attachments.

2012-10-09 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/#review12284 --- Great patch, thanks Andrew! I didn't test the patch locally yet, but

Re: Review Request: Attachments.

2012-10-08 Thread Andrew Kaplanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/ --- (Updated Oct. 8, 2012, 10:58 a.m.) Review request for wave and Yuri Zelikov. C