Re: Code reviews app

2014-01-16 Thread Andrew Kaplanov
Is it possible to update RB so to fix the bug of work with big patches? 2014/1/16 Yuri Z > Got a really fast reply from Infra - Gerrit is not an option. > I am not sure whether GitHub pull requests are fine with Apache, maybe > mentors can help here? > But from the technical point of view - Git

Re: Code reviews app

2014-01-15 Thread Yuri Z
Got a really fast reply from Infra - Gerrit is not an option. I am not sure whether GitHub pull requests are fine with Apache, maybe mentors can help here? But from the technical point of view - GitHub PR are a lot easier to work with. Checking a patch can be done with single Git command, instead o

Re: Code reviews app

2014-01-15 Thread Yuri Z
Judging by the comments in the issue, it doesn't look like Gerrit is a real option. Anyway, I left a comment there with the question. On Mon, Jan 13, 2014 at 6:33 PM, Ryan Hill wrote: > +1 for Gerrit > > > On Mon, Jan 13, 2014 at 3:35 AM, Thomas Broyer wrote: > > > On Sun, Jan 12, 2014 at 5:14

Re: Code reviews app

2014-01-13 Thread Ryan Hill
+1 for Gerrit On Mon, Jan 13, 2014 at 3:35 AM, Thomas Broyer wrote: > On Sun, Jan 12, 2014 at 5:14 PM, Yuri Z wrote: > > > Hi > > Until now we used ReviewBoard for code reviews. It's a powerful app and > it > > served us well, but it seems like there are a few pros and cons. > > As we recently

Re: Code reviews app

2014-01-13 Thread Thomas Broyer
On Sun, Jan 12, 2014 at 5:14 PM, Yuri Z wrote: > Hi > Until now we used ReviewBoard for code reviews. It's a powerful app and it > served us well, but it seems like there are a few pros and cons. > As we recently moved to Git, we have a new option - we can use the GitHub > forks - https://github.

Re: Code reviews app

2014-01-13 Thread Bruno Gonzalez (aka stenyak)
On 2014-01-12 17:14, Yuri Z wrote: Until now we used ReviewBoard for code reviews. It's a powerful app and it served us well, but it seems like there are a few pros and cons. As we recently moved to Git, we have a new option - we can use the GitHub forks - https://github.com/apache/incubator-w