[GitHub] incubator-wave issue #21: Remove atmosphere as websocket's provider

2017-04-20 Thread vega113
Github user vega113 commented on the issue: https://github.com/apache/incubator-wave/pull/21 I guess you could rebase your branch instead of opening a new one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] incubator-wave issue #21: Remove atmosphere as websocket's provider

2017-04-20 Thread pablojan
Github user pablojan commented on the issue: https://github.com/apache/incubator-wave/pull/21 Closing due to changes were made on top of another PR instead of master. Check new PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-wave issue #21: Remove atmosphere as websocket's provider

2017-04-18 Thread wisebaldone
Github user wisebaldone commented on the issue: https://github.com/apache/incubator-wave/pull/21 Please pull from the branch you based this off to get those little edits corrected. Other than the style issue LGTM and thank you for this. --- If your project is set up for it, you can r