Re: Roadmap

2015-03-27 Thread Patrick Coleman
Is there an implementable design anywhere for how a client/server split would work? It continually comes up as a blocking point preventing people from working on Wave, though I'm not familiar with plans for fixing it that maintain all required constraints. e.g. sharing business logic between clien

Re: JSON editing and move conflicts

2014-10-22 Thread Patrick Coleman
> > - I'm not sure if I want to make this OT type invertable. If we don't, finding the data that was actually deleted will be difficult > What are the costs of making it invertable? i.e. are there particular reasons not to? I guess for proper invertability, you'd need to copy all the data being m

Re: JSON editing and move conflicts

2014-10-21 Thread Patrick Coleman
> > My worry is that if someone else moves another file called rope.h to > the resources directory at the same time, I don't want the result to > ever be that one of our files gets deleted from disk. > If the client/server keeps recent operations in memory and supports undo / has their own logic t

Re: Wave, article on why wave was not enough to use

2014-02-04 Thread Patrick Coleman
I think it illustrates a better issue, where if you ask four people "Why didn't wave succeed?" they'll have four (or more!) different answers. e.g. in that document, the first few people list: speed, live typing, no xmpp/email integration, no killer app, not better than existing tools, so the

Re: Wave Kickstarter

2013-12-02 Thread Patrick Coleman
The proposal seems to include rewriting the OT stack, changing the language(s) the client and server are written in, and moving to github. If this is the case, is there any point in still being called Wave? It sounds like not much will be able to be transferred other than knowledge, so is there an

Re: Wave-in-a-box I can't see how to write a message

2013-10-07 Thread Patrick Coleman
Oops, looks like a long-time TODO has finally struck, if it's the one here on setBaseAndExtent: https://svn.apache.org/repos/asf/incubator/wave/trunk/src/org/waveprotocol/wave/client/editor/selection/html/SelectionW3CNative.java?p=1227271 In short, we used QuirksConstants to try to decide at the p

Re: Wave Future Options

2013-06-13 Thread Patrick Coleman
Fascinating thread, it's been great to follow the huge increase in interest of late :) One question that I'm hoping might get answered before people rewrite anything: is there a plan for keeping the OT implementations of federated clients/servers in sync? It's a requirement both for federation to

Re: Review Request: Line-through editor shortcut

2013-03-20 Thread Patrick Coleman
The description mentions "Alt-shift-5", but it seems like you've switched it to Ctrl-Shift-5? Note that docs on mac has Alt-shift-5, but also the other styling options (bold, italic, ...) are all OPTION_ rather than CTRL_ (so macs can use the command key). As this is a simple style shortcut, it's

Re: Review Request: Implementing the feature "New wave with the participants of the current wave"

2012-10-22 Thread Patrick Coleman
gt; Long HTML insertions like this are often troublesome in terms of XSS attacks and general readability. My recommendation would be to have something like openButton() and closeButton() which take the css, type, title etc, like the other open/close m

Re: Review Request: Horizontal lines in the editor

2012-10-04 Thread Patrick Coleman
> On Oct. 1, 2012, 8:57 a.m., Patrick Coleman wrote: > > Hard to tell from reading the code, but out of interest, what happens if > > the line element has content after it? > > e.g. Some textmore text > > in HTML is special as it can't have children (I b

Re: Review Request: Horizontal lines in the editor

2012-10-01 Thread Patrick Coleman
happens if the line element has content after it? e.g. Some textmore text in HTML is special as it can't have children (I believe), so this might be a contraint we want to enforce here too. - Patrick Coleman On Sept. 30, 2012, 2:56 p.m., Vicente J. Ruiz Jurado

Re: Newbie question about working with Wave Documents

2012-09-14 Thread Patrick Coleman
Sounds good - in regards to the two points you mention: 1) XML/DOM model is found in model/document; see e.g. https://svn.apache.org/repos/asf/incubator/wave/trunk/src/org/waveprotocol/wave/model/document/MutableDocument.java or model/document/raw/RawDocument for examples of what you can access. (p

Re: renderers that generate local nodes

2012-07-23 Thread Patrick Coleman
I'm not sure about the first part, but for the second - from memory, style annotations also generate local nodes (l:s from memory) at style boundaries that are converted into styled elements in DOM. There were some other ideas of stuff keeping client state in local nodes but I don't believe much e

Re: editor handling events vs tracking DOM changes

2012-05-10 Thread Patrick Coleman
That's a good summary - For Wave we had the approach that we should take the approach of leaving some stuff to the browser, and doing some stuff manually; so for things like keyboard navigation, we let the browser do what it does, then figure out what changed - it's possible to do that manually in

Re: how typing updates the editor's DOM

2012-04-25 Thread Patrick Coleman
Check out ContentTextNode: https://svn.apache.org/repos/asf/incubator/wave/trunk/src/org/waveprotocol/wave/client/editor/content/ContentTextNode.java editor/content/<...> includes the DOM which map the wave document to DOM, with ContentTextNode mapping to Text nodes although due to browser treatme

Re: WiaB client code usage in the wild (a.k.a Undercurrent in Blogger)

2012-02-07 Thread Patrick Coleman
On 6 February 2012 12:50, David Hearnden wrote: > On Mon, Feb 6, 2012 at 12:36 PM, Thomas Wrobel > wrote: > > > ".e., to have a build setup that has user-agent specific builds, > > with compile-time minimization, and also an all-agent build? It might > > take > > some GWT-fu to set that up."

WiaB client code usage in the wild (a.k.a Undercurrent in Blogger)

2012-01-16 Thread Patrick Coleman
Fellow wave-dev'ers; For those who missed the recent announcement, my current project (Blogger) just launched threaded commenting: http://buzz.blogger.com/2012/01/engage-with-your-readers-through.html The reason I'm emailing here though is that all the comment rendering code uses the Undercurrent

Re: wave-editor set doodad over selection

2011-08-10 Thread Patrick Coleman
Nice demo! For some tools useful for getting information from a document, I'd recommend looking at DocHelpers: http://code.google.com/p/wave-protocol/source/browse/src/org/waveprotocol/wave/model/document/util/DocHelper.java - in particular, getText(doc, start, end) is likely useful if you can get

Re: Wave-editor: insert doodad

2011-07-03 Thread Patrick Coleman
I'm not sure of your exact usage, but .locate(int) is part of LocationMapper, and goes with .getLocation(point) essentially, the editor's document is both a DOM document (with ContentNodes, -Elements and -TextNodes), indexable by 'Points' (= defined by parent + child after) but also an OT-aware doc