Re: Client-Server Protocol

2014-01-14 Thread Yuri Z
WIAB is written in Java/GWT so there are no JS files in the source. Client files are located under: https://github.com/apache/incubator-wave/tree/master/src/org/waveprotocol/box/webclient - WIAB specific client stuff https://github.com/apache/incubator-wave/tree/master/src/org/waveprotocol/wave/cli

Client-Server Protocol

2014-01-14 Thread Jim Keener
Is there a good example of a client in the repository anywhere? I'm trying to understand where the JS file(s) are that handle the communication specifically (separate from the GWT ui?). Also, I remember there being a command line client many moons ago, but I'm foggy about that. Does that sti

Re: Licenses on generated files

2014-01-14 Thread Ali Lown
Since we are shipping them as part of the product, and not as something that the user must build themselves, I think they must have a ASF header. Ali On 14 Jan 2014 17:57, "Yuri Z" wrote: > We have a lot of Java sources which are generated by the protobuf tool. > They are included for convenienc

Re: Review Request 16698: MongoDB implementation for the delta store

2014-01-14 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16698/#review31745 --- I have an issue with binary patches, can you maybe create a pull req

Re: Review Request 16751: MongoDB store for deltas

2014-01-14 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16751/#review31744 --- I have an issue with binary patches, can you maybe create a pull req

Licenses on generated files

2014-01-14 Thread Yuri Z
We have a lot of Java sources which are generated by the protobuf tool. They are included for convenience so the end users won't need to install the protobuf. The question is, whether these generated files should have the Apache license?

Re: Review Request 16698: MongoDB implementation for the delta store

2014-01-14 Thread Ben Hegarty
Hi Yuri, I was wondering if you had a chance to test this diff and run the mongodb unit tests? I noticed that the Mongodb unit tests had a fundamental flaw that caused the database to hang around, they were actually using the 'fedone' DB and not the unit test defined database name, I also noticed