Re: Review Request: Implementing the feature "New wave with the participants of the current wave"

2012-10-22 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7353/ --- (Updated Oct. 22, 2012, 8:41 p.m.) Review request for wave. Changes --- T

Re: Review Request: Make the 'presented' websocket address configurable: BadCertificate exception

2012-10-22 Thread Ali Lown
> After this patch, I found I got "A turbulence detected!" as soon as I opened > the page, and BadCertificate errors in the log. > > To save others some debugging, the problem was that the patch changes the > domain in the wss:// URL from the domain used by the user to access the > site, to the one

Re: Review Request: SSL Client Authentication

2012-10-22 Thread Ali Lown
> On Aug. 10, 2012, 10:02 a.m., Yuri Zelikov wrote: > > The patch LGTM - just minor comments. I still had no time to test it > > properly, but if it works for you, we can commit it. > > IMO, it would be great to add a script/clear instructions on how to > > generate self signed certificate/CA,

Re: Review Request: Implementing the feature "New wave with the participants of the current wave"

2012-10-22 Thread Patrick Coleman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7353/#review12654 --- Really nice feature :) One thing to also to consider in the future is

Re: Review Request: Make the 'presented' websocket address configurable: BadCertificate exception

2012-10-22 Thread Vicente J. Ruiz Jurado
El 22/10/12 12:36, Thomas Leonard escribió: > After this patch, I found I got "A turbulence detected!" as soon as > I opened the page, and BadCertificate errors in the log. > > To save others some debugging, the problem was that the patch > changes the domain in the wss:// URL from the domain used

Re: Review Request: Attachments.

2012-10-22 Thread Andrew Kaplanov
> On Oct. 21, 2012, 4:36 p.m., Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/server/persistence/file/FileAttachmentStore.java, > > line 131 > > > > > > proto.getPB() -> Can we rename getPB() method into something

Re: Review Request: Make the 'presented' websocket address configurable: BadCertificate exception

2012-10-22 Thread Thomas Leonard
After this patch, I found I got "A turbulence detected!" as soon as I opened the page, and BadCertificate errors in the log. To save others some debugging, the problem was that the patch changes the domain in the wss:// URL from the domain used by the user to access the site, to the one in htt

Re: Releasing...

2012-10-22 Thread Ed - 0x1b, Inc.
On Sun, Oct 21, 2012 at 8:28 PM, Michael MacFadden wrote: > Please referer to the previous email from Angus posted to the dev list > titles "Release Update" on 9/29/12: > > -- > > Hi All, > The last review for licensing stuff is up, i'd appreciate it if you all > looked at it and pointed out a

Re: Review Request: Attachments.

2012-10-22 Thread Andrew Kaplanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/ --- (Updated Oct. 22, 2012, 9:05 a.m.) Review request for wave and Yuri Zelikov. C