I was thinking a menu would be preferable because people coming from Gwave
would he a familiar UI and because then the menu would exist for future UI
additions.
—Zachary “Gamer_Z.” Yaro
On Sep 30, 2012 6:20 AM, "Wave Grove" wrote:
> Since we currently only have this feature to add to that menu I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7364/
---
Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
Descript
> On Sept. 30, 2012, 2:09 a.m., Angus Turner wrote:
> >
>
> Angus Turner wrote:
> sorry my bad, it said
> 'some tests would be great if possible'
>
> rocklund wrote:
> I'm not sure if it is possible to add any testing for this since it is
> mostly UI-driven code. I couldn't find an
> On Sept. 30, 2012, 2:09 a.m., Angus Turner wrote:
> >
>
> Angus Turner wrote:
> sorry my bad, it said
> 'some tests would be great if possible'
>
> rocklund wrote:
> I'm not sure if it is possible to add any testing for this since it is
> mostly UI-driven code. I couldn't find an
Since we currently only have this feature to add to that menu I thought it
would make more sense to have it as a button. Then when we get more wave
options we could create a menu and put this function in there as well. On
the other hand I see the point of having it in a menu to clarify that it is
a
> On Sept. 30, 2012, 2:09 a.m., Angus Turner wrote:
> >
>
> Angus Turner wrote:
> sorry my bad, it said
> 'some tests would be great if possible'
I'm not sure if it is possible to add any testing for this since it is mostly
UI-driven code. I couldn't find any tests on wave opening and
Oops I thought I did :)
My internet has been a bit stuffy lately...
Thanks
Angus Turner
angusisf...@gmail.com
On Sun, Sep 30, 2012 at 6:52 PM, Ali Lown wrote:
> > The last review for licensing stuff is up, i'd appreciate it if you all
> > looked at it and pointed out any errors i've made.
>
>
> The last review for licensing stuff is up, i'd appreciate it if you all
> looked at it and pointed out any errors i've made.
I can't see it in my 'incoming reviews' section.
I did find it eventually (https://reviews.apache.org/r/7363/), and it
appears you didn't add any groups for the review.
I
