[vpp-dev] Subif/VLAN Questions

2017-06-02 Thread Jon Loeliger
Hey Audience, Guess what! (What?) I have another set of questions! This time, VLAN/Subif related. Start with the easy one: Is the API call create_vlan_subif slated for removal or deprecation? I think it should be. It seems to me to be totally redundant and a subset of the more general API ca

Re: [vpp-dev] VPP API improvements - community discussion.

2017-06-13 Thread Jon Loeliger
On Mon, Jun 5, 2017 at 5:24 AM, Neale Ranns (nranns) wrote: > > Dear VPP community, > > Some of the feedback we get from users of VPP is that the client-side API is > not particularly user-friendly – we would like to address this. I don't know about user friendly; I can wade through the technica

[vpp-dev] Packet Trace API?

2017-06-28 Thread Jon Loeliger
Hey vpp-dev, Is there no API to enable packet tracing, and then get the trace buffer(s)? Is there any plan to do so? Or is this the whole point of the ioam code and I just don't see the connection yet? They seem different to me. Thanks, jdl ___ vpp-d

Re: [vpp-dev] Regarding C API

2017-08-23 Thread Jon Loeliger
On Tue, Aug 15, 2017 at 7:45 PM, Burt Silverman wrote: > It appears that there are 2 typos not just one: try -lvatplugin. > > Burt I suck at this. Sorry, jdl ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] VPP S-NAT rename

2017-08-23 Thread Jon Loeliger
On Mon, Aug 21, 2017 at 2:39 AM, Ole Troan wrote: > Hi, > > The 'S' in VPP's S-NAT plugin name has often been confused with Linux' > "Source NAT". The 'S' originally stood for "Simple", implying that it was a > less complex implementation of NAT than the previous VCGN implementation. > > Because

[vpp-dev] Missing include file. Again.

2017-08-23 Thread Jon Loeliger
Folks, I get the following compilation error with current (ie, commit af3d9771dbf89087d3e8bed11aca0a2efa5d7bc8 Author: Marek Gradzki Date: Fri Aug 18 08:47:48 2017 +0200 ) top-of-tree builds: CC tap_inject.c In file included from /usr/include/vpp/api/vpe_all_api_h.h:25:0,

[vpp-dev] Augment 'make test' with C build tests?

2017-08-23 Thread Jon Loeliger
Damjan and others, Over the past 6 or 8 months, we have had several build failures due to missing include files in the installation of built RPMs. It is a really simple C test to identify the failure. Here is an almost minimal example: #include #include #include #include

Re: [vpp-dev] Missing include file. Again.

2017-08-23 Thread Jon Loeliger
On Wed, Aug 23, 2017 at 1:30 PM, Florin Coras wrote: > Hi Jon, > > There was a pending patch for that but apparently it got abandoned. Here’s a > fix [1] that we’ll merge as soon as it passes verify. > > Sorry for the inconvenience. > > Regards, > Florin > > [1] https://gerrit.fd.io/r/#/c/8188/ A

Re: [vpp-dev] Augment 'make test' with C build tests?

2017-08-23 Thread Jon Loeliger
On Wed, Aug 23, 2017 at 2:25 PM, Dave Wallace wrote: > Jon, > > I think this is an excellent idea as your example is clearly a test escape > that we should be detecting in our CI infra. > > However, I'm not sure if "make test" is the appropriate place to add this > check. IMHO, this would be bett

Re: [vpp-dev] VPP S-NAT rename

2017-08-23 Thread Jon Loeliger
On Wed, Aug 23, 2017 at 2:56 PM, Ole Troan wrote: > They are now both there in parallel. With a warning in the wiki that the old > one will be removed after 17.10. > https://wiki.fd.io/view/VPP/NAT#API_.28new_after_renaming.29 > > Does that work for you? Yep! jdl __

Re: [vpp-dev] Augment 'make test' with C build tests?

2017-08-23 Thread Jon Loeliger
> On Wed, Aug 23, 2017 at 2:25 PM, Dave Wallace wrote: > > IMO, "in-tree" .vs. "out-of-tree" really boils down to decoupling the app's > "Makefile.am" the rest of the vpp autotools structure/configuration. For > example, I ran into the same issue with > .../vppsb/vcl-ldpreload/src/Makefile.am (w

Re: [vpp-dev] Augment 'make test' with C build tests?

2017-08-23 Thread Jon Loeliger
>> Feel free to nix this patch, of course, but I'm not really sure where >> or how to get an equivalent test into the ..extras/apps approach yet. > > Cool. Give me a few days, and I'll revise this patch to consolidate the > test apps and integrate the 'make test-c-build' validation into 'make > ve

Re: [vpp-dev] VPP S-NAT rename

2017-08-24 Thread Jon Loeliger
On Wed, Aug 23, 2017 at 2:56 PM, Ole Troan wrote: > Does that work for you? Ole, So, I have renamed SNAT --> NAT/NAT44 as needed now. That's all fine. Got caught by this failure mode, though I now have this code: plugin_name = format(0, "nat_%08x%c", nat_api_version, 0); base

[vpp-dev] Static Route Data API Data Structures

2017-08-27 Thread Jon Loeliger
VPP-ites, I am delving into the world of static routes. I am clearly missing some basic information and would like some help understanding how static routes work. For starters, I'm a little unclear on what exactly these items are, or what they represent or hold, and their relationship to each ot

Re: [vpp-dev] Static Route Data API Data Structures

2017-08-29 Thread Jon Loeliger
On Tue, Aug 29, 2017 at 4:21 AM, Neale Ranns (nranns) wrote: > Hi Jon, > > (apologies for repeating some of what you already know, but from the top…) > > A VRF is virtualisation of a router’s *IP* routing and forwarding. VRFs are > typically identified by a name (and again typically named to refe

Re: [vpp-dev] Static Route Data API Data Structures

2017-08-29 Thread Jon Loeliger
On Tue, Aug 29, 2017 at 4:21 AM, Neale Ranns (nranns) wrote: > Hi Jon, > > (apologies for repeating some of what you already know, but from the top…) > > A VRF is virtualisation of a router’s *IP* routing and forwarding. Neale, Also, for the benefit of other Wiki Doc Searchers, I have captured y

Re: [vpp-dev] Static Route Data API Data Structures

2017-08-29 Thread Jon Loeliger
On Tue, Aug 29, 2017 at 4:21 AM, Neale Ranns (nranns) wrote: > Hi Jon, > Neale, > By ‘IP’ in this context we mean IPv4 and IPv6 and unicast and multicast > (known as sub-address families or SAFIs). To provide this separation we > therefore need 4 ‘tables’ per-VRF, one for each SAFI. You say 4 h

Re: [vpp-dev] Static Route Data API Data Structures

2017-08-29 Thread Jon Loeliger
> A table doesn't know its Address Family, except by the inspection of > the types of routes within it, right? Ooo. My bad. Reading the ip_table_add_del API call, a Table clearly knows what address family it holds: autoreply define ip_table_add_del { u32 client_index; u32 co

Re: [vpp-dev] Static Route Data API Data Structures

2017-08-29 Thread Jon Loeliger
>> As with all things VPP the allocation of the data-structure that represents >> the LPM-DB comes from a memory pool. This data-structure thus has an >> associated pool index – this is the FIB index. So, there is a one to one >> mapping between the externally visible and client assigned ‘table ID’

[vpp-dev] VPP API Message Multi-Registration Question

2017-09-15 Thread Jon Loeliger
Folks, We have a need to re-register API message handlers. (Think re-fork/exec scenarios for daemons.) Today, we register handlers via a call to this function: vl_msg_api_set_handlers (int id, char *name, void *handler, void *cleanup, void *endian, void *print, int s

[vpp-dev] Multiple vppctl Considered Harmful

2017-09-19 Thread Jon Loeliger
Folks, While I appear to be able to run a single vppctl up against VPP, if I then start a second one, to the same VPP process, VPP immediately aborts. It's pretty unfriendly. EAL: Invalid NUMA socket, default to 0 EAL: Invalid NUMA socket, default to 0 DPDK physical memory layout: Segment 0:

Re: [vpp-dev] Static Route Data API Data Structures

2017-09-21 Thread Jon Loeliger
On Tue, Aug 29, 2017 at 9:37 AM, Neale Ranns (nranns) wrote: > > Hi Jon, > > The new API does not function correctly in master at this time. If you want > to ride on the bleeding edge with the new API, the code I intend to commit is > (complete AFAICT) here: > https://gerrit.fd.io/r/#/c/7819/

Re: [vpp-dev] 回复: How to get interface stats using C api?

2017-09-27 Thread Jon Loeliger
On Tue, Sep 26, 2017 at 9:47 PM, Keith Burns wrote: > Apologies, > > It's a callback. > > We probably need some decent literature written for how to consume the > various C, C++, Python and Lua APIs > > If you have a preference for any of those languages I could write a brief > client program for

[vpp-dev] Adding IP Addr to Multiple IFs

2017-09-28 Thread Jon Loeliger
Packet Handlers, I have a question regarding adding IP address on multiple interfaces. I know. Seems like it should be obvious and easy. But I am not really a Domain Expert here. So questions about both expected behavior and a possible bug. We'll see. Let's start with this sequence of vppctl

Re: [vpp-dev] Adding IP Addr to Multiple IFs

2017-10-02 Thread Jon Loeliger
On Fri, Sep 29, 2017 at 3:33 PM, Neale Ranns (nranns) wrote: > Hi Jon, > > > > We don’t support overlapping subnets on interfaces. I was trying to fix > the cases where it is errorneously allowed with this patch: > > https://gerrit.fd.io/r/#/c/8057/ > > but I’ve not yet found all the CSIT failu

Re: [vpp-dev] Mac Address Api Changes

2017-10-10 Thread Jon Loeliger
On Tue, Oct 10, 2017 at 2:41 PM, John Lo (loj) wrote: > The two APIs affected are the older ones in L2FIB which use “u64 mac” > instead of “u8 mac[6]” to pass MAC addresses: > > ·L2fib_add_del > > ·L2_fib_table_details > > > > I believe it is a good change to reduce confusion wrt

Re: [vpp-dev] 17.10 draft release notes

2017-10-25 Thread Jon Loeliger
On Wed, Oct 25, 2017 at 7:28 AM, Ole Troan wrote: > Hi Florin, > Hi Ole, > What about something like this? > > #!/usr/bin/env python > import os, fnmatch, subprocess > starttag = 'v17.07' > endtag = 'v17.10-rc2' > apifiles = [] > for root, dirnames, filenames in os.walk('.'): > for filenam

[vpp-dev] Assumed "deny" at end of ACLs?

2017-10-30 Thread Jon Loeliger
Hi VPP Gurus, Is there an assumed "deny all" at the end of an ACL rule list? Or some form of "route to dpo-drop"? Anything like that? Or is that something that use must explicitly encode into an ACL list? Is this stated somewhere in the Wiki and I just missed it? Thanks, jdl __

Re: [vpp-dev] Assumed "deny" at end of ACLs?

2017-10-30 Thread Jon Loeliger
On Mon, Oct 30, 2017 at 3:34 PM, Andrew Yourtchenko wrote: > Jon, > > Assuming it’s ACL plugin that you ask about, yes - if none of the ACLs in > the list of ACLs applied to interface in a given direction matches, it’s > the same as deny. > > --a Excellent! Thank you! jdl

Re: [vpp-dev] Assumed "deny" at end of ACLs?

2017-10-31 Thread Jon Loeliger
On Mon, Oct 30, 2017 at 3:38 PM, Jon Loeliger wrote: > On Mon, Oct 30, 2017 at 3:34 PM, Andrew Yourtchenko > wrote: > >> Jon, >> >> Assuming it’s ACL plugin that you ask about, yes - if none of the ACLs in >> the list of ACLs applied to interface in a given di

[vpp-dev] Neighbor DUMP Takes Forever

2017-11-08 Thread Jon Loeliger
Hi Folks, OK, maybe the Neighbor DUMP doesn't literally take forever. But it sure does take too long! Here is the problem: When one goes to DUMP the Neighbor tables, one has no idea which interface might have ARP/NDP entries on them. So one determines the total number of interfaces, and then on

Re: [vpp-dev] Neighbor DUMP Takes Forever

2017-11-08 Thread Jon Loeliger
On Wed, Nov 8, 2017 at 12:25 PM, Jon Loeliger wrote: > Hi Folks, > > OK, maybe the Neighbor DUMP doesn't literally take forever. > But it sure does take too long! Here is the problem: > The problem appears to be PEBCAK. jdl ___

Re: [vpp-dev] Neighbor DUMP Takes Forever

2017-11-08 Thread Jon Loeliger
On Wed, Nov 8, 2017 at 12:37 PM, Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) wrote: > Hi Jon, > > the usual way to deal with possible-empty result sets is to wrap the > call with a control-ping. > > 1.) send control-ping > 2.) send e.g. sw_interface_dump > 3.) start collecting sw

[vpp-dev] And Boost Log too?

2017-11-08 Thread Jon Loeliger
Folks, Looks like VPP top-of-tree needs boost_log now. And it isn't in the install-deps. And my "yum install boost-log" goes MIA. Hints? Thanks, jdl g++ -o /home/jdl/workspace/vpp/build-root/vom_test/vom_test -I /home/jdl/workspace/vpp/src/vpp-api/ -std=c++11 -g -Wall -pthread -I/home/jdl/w

Re: [vpp-dev] And Boost Log too?

2017-11-08 Thread Jon Loeliger
On Wed, Nov 8, 2017 at 2:29 PM, Neale Ranns (nranns) wrote: > Hi Jon, > > > > It doesn’t need it. I must have left that in by mistake. I’ll take it out. > Awesome. Thanks! jdl ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/l

[vpp-dev] Missing udp.api.h header file?

2017-11-09 Thread Jon Loeliger
Folks, Anyone recognize this one? CC my_af_packet.c In file included from /usr/include/vpp/api/vpe_all_api_h.h:25:0, from /usr/include/vpp/api/vpe_msg_enum.h:24, from my_af_packet.c:14: /usr/include/vnet/vnet_all_api_h.h:64:30: fatal error: vnet/udp/udp.api.h

Re: [vpp-dev] Missing udp.api.h header file?

2017-11-09 Thread Jon Loeliger
On Thu, Nov 9, 2017 at 4:29 PM, Florin Coras wrote: > Hi Jon, > > This dates back to a couple of days ago. > Hey, I don't pull *every* day... :-) > Fix is on the way … > > Florin > Thank you! jdl ___ vpp-dev mailing list vpp-dev@lists.fd.io https:/

[vpp-dev] ACL Build/Test Issues

2017-11-10 Thread Jon Loeliger
Folks, Every error from the ACL implementation is -1. Generically bad. Without regard for what might be more useful to an upper-layer UI. So I submitted a patch to help this situation some. https://gerrit.fd.io/r/#/c/9383/ I have built and tested it locally, but it fails the Verify Tests becaus

Re: [vpp-dev] ACL Build/Test Issues

2017-11-10 Thread Jon Loeliger
On Fri, Nov 10, 2017 at 5:54 PM, Andrew Yourtchenko wrote: > Hi Jon, > > On 10 Nov 2017, at 23:11, Jon Loeliger wrote: > > Folks, > > Every error from the ACL implementation is -1. Generically bad. > Without regard for what might be more useful to an upper-layer UI.

Re: [vpp-dev] ACL Build/Test Issues

2017-11-10 Thread Jon Loeliger
Chris, On Fri, Nov 10, 2017 at 8:27 PM, Luke, Chris wrote: > If you’re wondering where the tests are: > > > > $ ls test/*acl* > > test/test_acl_plugin_conns.py test/test_acl_plugin_macip.py > > test/test_acl_plugin_l2l3.py test/test_acl_plugin.py > Ah, excellent! > Chris. > Thanks! jdl _

[vpp-dev] ACL API Change

2017-11-13 Thread Jon Loeliger
Folks, So, yeah, I was just blind-sided by an API change in the ACL code. Not to name names, or anything by it was commit 36ea2d6d3a67a60534a7c2b58551688858a1ce7f One armed NAT (VPP-1035) Use a single physical interface in order to accomplish NAT44/NAT64. That patch also introduced

Re: [vpp-dev] Discussion Topic: creating demo branches in git.fd.io/vpp

2017-11-15 Thread Jon Loeliger
On Wed, Nov 15, 2017 at 4:17 PM, Dave Wallace wrote: > Folks, > > Per the action item from this yesterday's VPP weekly meeting, I'm asking > for opinions from the VPP community on allowing the creation of demo > branches in the VPP git repo. > > ... > > Pro: Will allow utilization of LF infra to

Re: [vpp-dev] Deprecate [S]NAT APIs

2017-11-20 Thread Jon Loeliger
On Mon, Nov 20, 2017 at 9:59 AM, Neale Ranns (nranns) wrote: > > From src/plugins/nat/nat.api > > /* > * Old "snat" APIs, will be deprecated after 17.10 > */ > > is it time? > > /neale > As far as I am concerned, they can go now! Thanks, jdl ___ vpp

[vpp-dev] i40e in a sorry state?

2017-12-05 Thread Jon Loeliger
Guys, I've updated VPP to vpp.x86_64 0:18.01-rc0~405_g7f0d1d3 and when I enable a interface, I get this love note: i40e_dev_interrupt_handler(): ICR0: HMC error Aborted This used to work, of course. Some more details below. Any notions? Thanks, jdl # cat /etc/vpp/startup.conf unix

Re: [vpp-dev] i40e in a sorry state?

2017-12-06 Thread Jon Loeliger
On Wed, Dec 6, 2017 at 5:17 AM, Kinsella, Ray wrote: > > We may need the contents of PFHMC_ERRORINFO and PFHMC_ERRORDATA registers > to figure this out. > I suspect that this may be something to do with interrupts being enabled. > However from reading the code, looks like interrupts should be dis

[vpp-dev] MACIP ACL replace causes ip4_table_index change?

2017-12-08 Thread Jon Loeliger
Hey VPP Fans, I've detected a slight anomaly in the handling of MACIP ACLs, and would like some help tracking down the right solution. I start by making a MACIP ACL. vppctl shows: vpp# show acl-plugin macip acl MACIP acl_index: 0, count: 1 (true len 1) tag {bob} is free pool slot: 0 ip4_table_

Re: [vpp-dev] MACIP ACL replace causes ip4_table_index change?

2017-12-08 Thread Jon Loeliger
On Fri, Dec 8, 2017 at 10:56 AM, Jon Loeliger wrote: > > vpp# show acl-plugin macip acl > MACIP acl_index: 0, count: 1 (true len 1) tag {bob} is free pool slot: 0 > ip4_table_index 0, ip6_table_index 0, l2_table_index 0 > rule 0: ipv4 action 0 ip 0.0.0.0/0 mac 00:00:00:00:

Re: [vpp-dev] MACIP ACL replace causes ip4_table_index change?

2017-12-08 Thread Jon Loeliger
On Fri, Dec 8, 2017 at 11:24 AM, Jon Loeliger wrote: > On Fri, Dec 8, 2017 at 10:56 AM, Jon Loeliger wrote: > >> >> vpp# show acl-plugin macip acl >> MACIP acl_index: 0, count: 1 (true len 1) tag {bob} is free pool slot: 0 >> ip4_table_index 0, ip6_table_index 0

Re: [vpp-dev] MACIP ACL replace causes ip4_table_index change?

2017-12-08 Thread Jon Loeliger
On Fri, Dec 8, 2017 at 12:34 PM, Andrew Yourtchenko wrote: > Jon, > > Do you have an api trace you could throw in my direction unicast ? > I'd have to work at that quite a bit as I am using a totally new and different UI to drive these API calls... I can outline it for you: macip_index = c

Re: [vpp-dev] MACIP ACL replace causes ip4_table_index change?

2017-12-08 Thread Jon Loeliger
On Fri, Dec 8, 2017 at 12:55 PM, Jon Loeliger wrote: > > > >> We need to iterate the am->macip_acl_by_sw_if_index and for interfaces >> which have the acl in question applied, reapply these new tables to these >> interfaces so the already active macip acl rem

Re: [vpp-dev] MACIP ACL replace causes ip4_table_index change?

2017-12-09 Thread Jon Loeliger
On Sat, Dec 9, 2017 at 8:16 AM, Andrew 👽 Yourtchenko wrote: > Jon, > Hi Andrew, Thanks for taking a look at this issue! > on api trace: does the below work ? (even though the current scenario > is trivially reproducible, the api traces are very useful for tougher > cases, and save a lot of ty

[vpp-dev] Failing verify jobs

2017-12-30 Thread Jon Loeliger
Folks, So, I have a long-standing "DON'T MERGE"-ish patch that is a recurring rebase request to help identify failures of missing #include files in C API application biulds. It is: https://gerrit.fd.io/r/8189 It was recently rebased, and failed for an entirely different reason. That reason appe

[vpp-dev] Some memif API and Naming Questions

2018-01-13 Thread Jon Loeliger
Hi VPPeople, I am working on adding memif support to our system and need to design some User Interface pieces for it. I am having a bit of a hard time with one naming aspect of the memif components. Each memif entry has a unique u32 id assigned to it. Each memif entry requires a socket as part o

Re: [vpp-dev] Some memif API and Naming Questions

2018-01-14 Thread Jon Loeliger
On Sun, Jan 14, 2018 at 9:36 AM, Damjan Marion (damarion) < damar...@cisco.com> wrote: > Jon, > Hi Damjan, Thanks for answering my email! I think there are somethings I'm not quite understanding yet, so I have a few more questions and suggestions. > Each memif connection between master and sl

Re: [vpp-dev] Some memif API and Naming Questions

2018-01-14 Thread Jon Loeliger
On Sun, Jan 14, 2018 at 12:10 PM, Damjan Marion (damarion) < damar...@cisco.com> wrote: > > master 1: > create memif id 33 master socket /tmp/memif1.sock > > Interface name: memif-0/33 > Here! You know that because you had to look at "show int" or "show memif". What if earlier allocations of mem

Re: [vpp-dev] Some memif API and Naming Questions

2018-01-15 Thread Jon Loeliger
Hi Damjan, Let's try again. I've spoken with a colleague here and I think I may have misunderstood a few aspects of your proposal. Reviewing it with him, I think we can make it work! Let me review, and see if I understand (better) what you are saying and proposing. You said: On Sun, Jan 14, 2

Re: [vpp-dev] Heads up: VPPAPIGEN rewrite

2018-01-17 Thread Jon Loeliger
On Wed, Jan 17, 2018 at 2:25 AM, Ole Troan wrote: > Hi there, > > For a while there has been some interest in making the API language more > explicit. > This is a rewrite of the vppapigen generator with support for services {} > (like grpc), enums, output plugins, better error checking. > The ch

Re: [vpp-dev] Heads up: VPPAPIGEN rewrite

2018-01-18 Thread Jon Loeliger
On Thu, Jan 18, 2018 at 2:32 AM, Ole Troan wrote: > Hi Jon, > > I find embedded documentation (and excessive comments) problematic for > that exact reason. > Absolutely agree 100%. > We're never going to make them consistent. > Sadly, correct again. > Stepping back a little; I think we agre

[vpp-dev] Upcoming memif API and CLI changes.

2018-01-22 Thread Jon Loeliger
Folks, Just a heads-up that I have submitted a patch that alters both the API and the CLI for the memif functions. That patch is being reviewed and will (hopefully) be merge soon. Prior to the patch, the memif CLI supported a create and a delete command roughly like this: vppctl# create mem

[vpp-dev] RFC: Error Codes

2018-01-22 Thread Jon Loeliger
Hey VPP Aficionados, I would like to make a proposal for a new way to introduce error codes into the VPP code base. The two main motivations for the proposal are 1) to improve the over-all error messages coupled to their API calls, and 2) to clearly delineate the errors for VNET from tho

Re: [vpp-dev] RFC: Error Codes

2018-01-23 Thread Jon Loeliger
On Tue, Jan 23, 2018 at 8:12 AM, Ole Troan wrote: > Dear Dave, > > > I would be tempted to have the compiler emit > > "foreach__api_error" > macros [or similar]: > > > > #define foreach_foo_api_error \ > > _(SUCCESS, "Success") \ > > _(ERROR, "This didn't go well") > > > > To minimize pain in up

[vpp-dev] Re-verify a Commit?

2018-01-23 Thread Jon Loeliger
Hey vpp-dev-iants, How do I kick-off a re-verify request after a patch fails to verify properly. It is the mystery "unknown failure", so we just need to try to rebuild it again. Am I just blindly missing a "reverify" button on an otherwise inscrutable Gerrit page somewhere? Thanks, jdl

Re: [vpp-dev] Re-verify a Commit?

2018-01-23 Thread Jon Loeliger
On Tue, Jan 23, 2018 at 11:03 AM, Neale Ranns (nranns) wrote: > Hi Jon, > > > > Leave a code review comment of: > > recheck > > > > that will poke JJB to go do its thing again > > > > /neale > Ah, most excellent! ...and it looks like that has been done as well! Thanks, jdl __

[vpp-dev] Missing PLY ?

2018-01-24 Thread Jon Loeliger
Hey Kids, The new API Gen seems to want ply.lex, but I don't think it is listed as a dependency or something somewhere. Or maybe I have a really crappy Python. Dunno. Net effect, shown below, isn't good. Did I miss a step? Thanks, jdl make[4]: Entering directory `/home/jdl/workspace/vpp/bui

Re: [vpp-dev] Missing PLY ?

2018-01-24 Thread Jon Loeliger
On Wed, Jan 24, 2018 at 1:10 PM, Florin Coras wrote: > Hi Dad, > LOL. I deserved that. At least I didn't get "Hi Old Man". :-) Did you try the evergreen: > > make wipe > make install-dep > make build > Yeah, have done a "make install-dep" a couple times now and it doesn't improve things at

Re: [vpp-dev] Missing PLY ?

2018-01-24 Thread Jon Loeliger
> > Did you try the evergreen: >> >> make wipe >> make install-dep >> make build >> > > Yeah, have done a "make install-dep" a couple times now > and it doesn't improve things at all. > > I seem to be using python 2.7.5. > > > This seems to be working fine on centos7. They say ply is compatible wi

[vpp-dev] Building APIs outside of the VPP tree

2018-01-27 Thread Jon Loeliger
Folks, I have updated to top-of-vpp master, now at commit: commit fc804d9cf1d23a616ea7bce19fc65198aa978e6e Author: Florin Coras Date: Fri Jan 26 01:27:01 2018 -0800 Fix session/tcp coverity warnings I am trying to build a VPP API outside of the VPP tree. It now wants to r

Re: [vpp-dev] Building APIs outside of the VPP tree

2018-01-28 Thread Jon Loeliger
On Sat, Jan 27, 2018 at 3:37 PM, Jon Loeliger wrote: > Folks, > > I have updated to top-of-vpp master, now at commit: > > commit fc804d9cf1d23a616ea7bce19fc65198aa978e6e > Author: Florin Coras > Date: Fri Jan 26 01:27:01 2018 -0800 > > Fix se

Re: [vpp-dev] Building APIs outside of the VPP tree

2018-01-28 Thread Jon Loeliger
On Sun, Jan 28, 2018 at 2:42 PM, Ole Troan wrote: > Thanks for fixing it Jon! > I'm not sure there is anything much better than that. ;-) > > Cheers, > Ole I'll submit a real patch to Gerrit then. Thanks! jdl ___ vpp-dev mailing list vpp-dev@lists.fd

[vpp-dev] VXLAN Tunnel IF Names

2018-01-31 Thread Jon Loeliger
Hey Developers, I've turned my attention to the wondrous world of VXLANs! And with that, I stare into the Vast VXLAN API Abyss... My first question, as usual, involves the SW IF that is created by the vxlan tunnel create API call. The IF has a name that is once-again unknowable by the User who

[vpp-dev] Consolidatation of fib_ip_proto() functions?

2018-02-01 Thread Jon Loeliger
Neale, I have need of using a function like fib_ip_proto(), below, in yet another file. But rather than introduce a 5th copy of the same function, would you accept a patch that consolidated them all into one static inline in, say, fib_types.h where the FIB_PROTOCOL_* values are defined? Thanks, j

Re: [vpp-dev] VXLAN Tunnel IF Names

2018-02-02 Thread Jon Loeliger
On Wed, Jan 31, 2018 at 6:41 PM, John Lo (loj) wrote: > Hi Jon, > Hi John, Thanks for taking the time to get back to me on this! All VPP tunnel creation uses the mechanism of returning a sw_if_index of > the created tunnel. > I know. I get that. It works. > The name of the tunnel is then

Re: [vpp-dev] VXLAN Tunnel IF Names

2018-02-02 Thread Jon Loeliger
On Fri, Feb 2, 2018 at 3:08 PM, Jon Loeliger wrote: > > I have submitted a patch to Gerrit. When this passes "verify", I'll add > you to be > a Reviewer! > John, How do I run just these tests locally? I need to determine if these failures are due to my patch o

Re: [vpp-dev] VXLAN Tunnel IF Names

2018-02-04 Thread Jon Loeliger
On Wed, Jan 31, 2018 at 6:41 PM, John Lo (loj) wrote: > Hi Jon, > > > > All VPP tunnel creation uses the mechanism of returning a sw_if_index of > the created tunnel. The name of the tunnel is then followed by a number > being the instance or index to the tunnel struct vector. Thus, the first > V

Re: [vpp-dev] VXLAN Tunnel IF Names

2018-02-05 Thread Jon Loeliger
On Mon, Feb 5, 2018 at 9:29 AM, John Lo (loj) wrote: > Hi Jon, > Hi John, > I don’t think the renumber scheme, as used by vhost and tap interfaces, is > foolproof and can cause problems if used extensively for vxlan. On > creating an interface with renumber, it does not check if the instance

Re: [vpp-dev] VXLAN Tunnel IF Names

2018-02-05 Thread Jon Loeliger
On Mon, Feb 5, 2018 at 9:55 AM, Jon Loeliger wrote: > > > >> I think we must check and reject instance misuse for this to be >> acceptable. I doubt the renumber is really used much for vhost and tap >> interface (others please correct me if not true). >> > &g

Re: [vpp-dev] VXLAN Tunnel IF Names

2018-02-05 Thread Jon Loeliger
On Mon, Feb 5, 2018 at 11:48 AM, John Lo (loj) wrote: > One more thang, I would prefer to have a u32 instance number instead of > the 64 bytes if_name in the vxlan_tunnel_details API. -John > Hi John, I'll work up a patch re-spin using a hash-table, and I will include the if_name -> sw_if_ind

Re: [vpp-dev] VXLAN Tunnel IF Names

2018-02-05 Thread Jon Loeliger
John, On Mon, Feb 5, 2018 at 2:14 PM, John Lo (loj) wrote: > Thanks Jon. Seems we have an agreed upon an approach now. Just to be > sure, let me list the specifics: > > > > 1. We will get rid of custom_instance_by_real_instance vector in > vxlan_main_t > See #3 below. > 2. We will a

[vpp-dev] _mm_testz_si128 Woes

2018-02-19 Thread Jon Loeliger
Hey hey hey, I tried to build a variant of vppsb and failed miserably for lack of the __mm_testz_si128 symbol. >From whence does that arrive on my doorstep? I'm trying to figure out if vppsb needs to #define something new, or #include something first, or if my system is suddenly missing somethin

[vpp-dev] VXLAN Instances Not Freed Properly?

2018-02-23 Thread Jon Loeliger
John, et al, I stumbled across this interesting behavior in VXLAN tunnels: vpp# create vxlan tunnel src 1.2.3.4 dst 10.11.12.13 vni 1 instance 101 vxlan_tunnel101 vpp# create vxlan tunnel src 1.2.3.4 dst 10.11.12.13 vni 1 instance 101 del vpp# create vxlan tunnel src 1.2.3.4 dst 10.11.12.13 vni 1

Re: [vpp-dev] VXLAN Instances Not Freed Properly?

2018-02-23 Thread Jon Loeliger
On Fri, Feb 23, 2018 at 4:43 PM, John Lo (loj) wrote: > Hi Jon, > > > > I see the problem in the delete path where the hash_unset() call is using > the tunnel instance instead of the user_instance of the tunnel starting at > about line 558 of vxlan.c: > > > > vnet_delete_hw_interface (vnm,

Re: [vpp-dev] Upcoming memif API and CLI changes.

2018-02-27 Thread Jon Loeliger
Peter, > Trying to configure Memif: > > > > vat# memif_dump > > Sending ping id=714 > > memif0/0: sw_if_index 3 mac 02:fe:db:be:87:29 > >id 0 socket-id 0 role slave > >ring_size 1 buffer_size 0 > >state down link down > If you also dump the memif socket table you should see that sock

Re: [vpp-dev] Upcoming memif API and CLI changes.

2018-02-27 Thread Jon Loeliger
Peter, On Tue, Feb 27, 2018 at 11:09 AM, Jon Loeliger wrote: > Peter, > > vat# memif_socket_filename_add_del add id 1 filename /tmp/memif >> >> memif_socket_filename_add_del error: Misc >> >> >> >> vat# memif_create id 0 socket-id 1 master >>

[vpp-dev] Tap and Tap-inject

2018-02-28 Thread Jon Loeliger
Discuss: Two Things That Don't Work Together: Tap and Tap-inject In today's world of discord, we often stray into territory that seems benign and harmless; a world that should be harmonious and fruitful. Yet, a cursory inspection yields quizzical behavior, mysterious happenings, and hidden

Re: [vpp-dev] Tap and Tap-inject

2018-03-02 Thread Jon Loeliger
On Wed, Feb 28, 2018 at 5:59 PM, Jon Loeliger wrote: > Discuss: > > Two Things That Don't Work Together: Tap and Tap-inject > > In today's world of discord, we often stray into territory that seems > benign and harmless; a world that should be harmonious and

[vpp-dev] A Question about SPAN Dump Details

2018-03-12 Thread Jon Loeliger
John, et al, Could we add the "is_l2" flag into the SPAN details message so that we don't have to maintain global state about what type of detail is coming back? Happy to submit that patch if you are OK with the suggestion. Thanks, jdl

Re: [vpp-dev] VPP As A Router Between Namespaces - 10ms latency

2018-03-12 Thread Jon Loeliger
On Mon, Mar 12, 2018 at 3:57 AM, Sara Gittlin wrote: > Dear Florin, > > When using the command " create tap rx-ring-size 4096 tx-ring-size 4096 " > VPP create the devices with default names tap0, tap1, ..tapn. > > Is it possible for the user to set the name in the 'create' command line ? > > Tha

Re: [vpp-dev] make TEST=test_ip6 test failing on multiple machines, when NOT run as root.

2018-03-13 Thread Jon Loeliger
On Tue, Mar 13, 2018 at 5:47 AM, Klement Sekera wrote: > I would say that this should be worth the extra effort just to have the > same conditions. Otherwise the verify job does something different than > `make test` on your box and that could be confusing. > > Thanks, > Klement These days, 'ma

[vpp-dev] vppsb's librtnl is broken with top of VPP tree

2018-03-13 Thread Jon Loeliger
Hey VPP-dev Is it me? It's me, isn't it. jdl librtnl/mapper.c: In function 'mapper_add_del_route': librtnl/mapper.c:101:31: error: passing argument 10 of 'fib_table_entry_path_add' from incompatible pointer type [-Werror] FIB_ROUTE_PATH_FLAG_NONE);

[vpp-dev] Ccache vs VPPAPIGEN

2018-03-14 Thread Jon Loeliger
Good Evening Sports Fans, Have we got a match for you tonight! In this corner, ccache. Loved for it speed and hackery, hated for its invasive corruptibility. In the other corner, we have vppapigen, loved tool of the single-source definitions for all things yet hated as the monster that will not

Re: [vpp-dev] Ccache vs VPPAPIGEN

2018-03-15 Thread Jon Loeliger
On Thu, Mar 15, 2018 at 2:00 PM, Damjan Marion wrote: > > Lot of changes happened in this area in last 48 hours. There is no > bootstrap step needed anymore. > > Do you still see issues? > Damjan, I believe your changes have fixed things. Thanks! jdl

Re: [vpp-dev] make TEST=test_ip6 test failing on multiple machines, when NOT run as root.

2018-03-15 Thread Jon Loeliger
On Thu, Mar 15, 2018 at 1:54 PM, Damjan Marion wrote: > > Should be fixed now, issue was happening when VPP was allocating buffer > memory from 4K pages (running as non-root). > Damjan, It has gotten better, but I still see these: ==

Re: [vpp-dev] make TEST=test_ip6 test failing on multiple machines, when NOT run as root.

2018-03-15 Thread Jon Loeliger
On Thu, Mar 15, 2018 at 4:45 PM, Dave Barach wrote: > +1. Definitely try “make test” as root, and let folks know how it goes… > > > > *From:* vpp-dev@lists.fd.io *On Behalf Of *Damjan > Marion > *Sent:* Thursday, March 15, 2018 5:24 PM > *To:* vpp-dev@lists.fd.io > *Cc:* vpp-dev@lists.fd.io > *S

Re: [vpp-dev] make TEST=test_ip6 test failing on multiple machines, when NOT run as root.

2018-03-19 Thread Jon Loeliger
On Fri, Mar 16, 2018 at 3:33 AM, Klement Sekera wrote: > This looks kinda like you have old papi installed somewhere. > > Please try `make test-wipe` and let me know how it goes. > > Thanks, > Klement These are clean build of top-of-tree. The 'make test-wipe' has no effect. I think the proble

Re: [vpp-dev] make TEST=test_ip6 test failing on multiple machines, when NOT run as root.

2018-03-19 Thread Jon Loeliger
On Mon, Mar 19, 2018 at 10:40 AM, Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) wrote: > Can you please provide instructions to reproduce? > > I checked out latest master > I think we are not communicating. I checkout any top of tree commit over the past, oh three weeks or so, an

Re: [vpp-dev] make TEST=test_ip6 test failing on multiple machines, when NOT run as root.

2018-03-19 Thread Jon Loeliger
On Mon, Mar 19, 2018 at 10:55 AM, Burt Silverman wrote: > I believe the physmem/numa error is just to throw us off -- a code bug but > an innocuous one at least for non NUMA systems; Damjan would know more. > > Jon, I like your idea about it not quitting on the first error. And I > guess the "Fil

Re: [vpp-dev] make TEST=test_ip6 test failing on multiple machines, when NOT run as root.

2018-03-20 Thread Jon Loeliger
On Mon, Mar 19, 2018 at 5:23 PM, Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) wrote: > Hi Jon, > > > Just to confirm - what's your environment? > > Centos 7.4 jdl@bcc-1 $ uname -a Linux bcc-1 3.10.0-693.21.1.el7.x86_64 #1 SMP Wed Mar 7 19:03:37 UTC 2018 x86_64 x86_64 x86_64 GNU/L

Re: [vpp-dev] make TEST=test_ip6 test failing on multiple machines, when NOT run as root.

2018-03-20 Thread Jon Loeliger
On Tue, Mar 20, 2018 at 6:30 AM, Ole Troan wrote: > > I debugged this a bit further and it seems that sometimes when hopping > branches, the json files corresponding to APIs are not regenerated properly. > > What happens in vpp-papi is that if it founds a duplicate, it checks > whether it's the s

Re: [vpp-dev] make TEST=test_ip6 test failing on multiple machines, when NOT run as root.

2018-03-22 Thread Jon Loeliger
On Tue, Mar 20, 2018 at 9:44 AM, Jon Loeliger wrote: > On Tue, Mar 20, 2018 at 6:30 AM, Ole Troan wrote: > >> >> > >> > git clean -d -f -x . >> > and rebuilding everything fixes the issue >> > >> > Let me know if you see a different issue

[vpp-dev] Some DS Lite Questions

2018-03-29 Thread Jon Loeliger
Matus, et al, I am looking at the DS Lite CLI and API calls. I have a few questions. Is there no way to remove either the B4 or AFTR tunnel endpoint once it is set? It seems there is maybe a missing dslite_pool_addr_dump API call? Is there a future for the ip4_addr fields on the "set B4" and "

  1   2   3   >