Re: [vpp-dev] crash in new QoS code

2016-10-11 Thread David Hotham via vpp-dev
So back on the original crash that started this thread... I've been doing some digging, have a decent idea of what's going wrong, and would appreciate input on what the right approach / next steps towards fixing it should be. When the GRE tunnel is configured, VPP's main control thread causes a

Re: [vpp-dev] crash in new QoS code

2016-10-11 Thread David Hotham via vpp-dev
My startup.conf currently contains this: cpu { main-core 0 corelist-workers 1 corelist-hqos-threads 2, 3 } David From: Singh, Jasvinder [mailto:jasvinder.si...@intel.com] Sent: 11 October 2016 16:25 To: David Hotham; vpp-dev@lists.fd.io; Dumitrescu, Cristian Subject: RE: crash in new QoS c

[vpp-dev] undefined behaviour in dpdk_hqos_metadata_set?

2016-10-12 Thread David Hotham via vpp-dev
dpdk_hqos_metadata_set classifies traffic by selecting bits from each packet according to the configured masks. But what if the packet being inspected is shorter than expected? For example, the default configuration includes this: /* * Packet field to identify the pipe. * * Default v

[vpp-dev] HQoS pipe profiles

2016-10-12 Thread David Hotham via vpp-dev
Am I right in thinking that currently the only way to configure pipe profiles is via the source code and recompiling? ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] undefined behaviour in dpdk_hqos_metadata_set?

2016-10-12 Thread David Hotham via vpp-dev
ts.fd.io<mailto:vpp-dev-boun...@lists.fd.io> [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of David Hotham via vpp-dev Sent: Wednesday, October 12, 2016 11:33 AM To: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> Subject: [vpp-dev] undefined behaviour in dpdk_hqos_metadata_set? dpdk_hqos_meta

Re: [vpp-dev] HQoS pipe profiles

2016-10-13 Thread David Hotham via vpp-dev
oun...@lists.fd.io> [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of David Hotham via vpp-dev Sent: Wednesday, October 12, 2016 5:47 PM To: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> Subject: [vpp-dev] HQoS pipe profiles Am I right in thinking that currently the only way to configure pip

Re: [vpp-dev] crash in new QoS code

2016-11-09 Thread David Hotham via vpp-dev
Hello, I'd like to come back to this one. As below, the problem is that sometimes VPP's control thread generates eg ARP packets; and the HQoS code is not ready for this. I've submitted a proposed fix that checks: are we on an unexpected thread? And if so, skips the HQoS queueing. https://ger

[vpp-dev] HQoS queue statistics CLI

2016-11-14 Thread David Hotham via vpp-dev
Hi, I've written a VPP CLI command that acts as a front-end to rte_sched_queue_read_stats, for getting stats from DPDK's traffic HQoS code. Example call and output at the bottom. Is this something you'd be interested in taking into VPP? I've submitted https://gerrit.fd.io/r/3820, but on top o