[vpp-dev] packed enums

2020-05-02 Thread Christian Hopps
Some recent changes related to packed enums in the API have broken already written code for low level API use. I think the main commit that did this was the one that added __packed__ to the generated enum declaration, but there are the related changes that add the enum size declarations I guess.

Re: [vpp-dev] ACL question

2020-05-02 Thread Neale Ranns via lists.fd.io
From: Govindarajan Mohandoss Date: Friday 1 May 2020 at 21:15 To: "Neale Ranns (nranns)" , Andrew Yourtchenko Cc: "John Lo (loj)" , Paul Vinciguerra , "vpp-dev@lists.fd.io" , nd , Lijian Zhang , Jieqiang Wang , nd Subject: RE: [vpp-dev] ACL question Hi Neale, I tried to use the CLI for

bug in api generation [Re: [vpp-dev] packed enums]

2020-05-02 Thread Christian Hopps
The fallout is a bit worse than first anticipated. I converted my code to use the vl_api_*_t_endian functions rather than doing the hton*/ntoh* by hand (since a bunch of them were now doing the wrong thing), and discovered another bigger problem. Unions are not handled correctly by the generate

Re: [vpp-dev] route lookup api

2020-05-02 Thread Christian Hopps
I was able to do a minimal test on it so I submitted, but please review as well. :) https://gerrit.fd.io/r/c/vpp/+/26829 Thanks, Chris. > On Apr 28, 2020, at 12:08 PM, Jon Loeliger via lists.fd.io > wrote: > > Chris, > > If you can shoot me the patch, as is, I will rebase and submit it? >