Re: [vpp-dev] FW: Coverity build failed with 18 errors

2017-11-10 Thread Neale Ranns (nranns)
Hi Chris, I just pushed: https://gerrit.fd.io/r/#/c/9370/ to fix the use of integer types in BIER. I’ll look at the VOM ones too. /neale -Original Message- From: on behalf of Chris Luke Date: Thursday, 9 November 2017 at 22:05 To: "vpp-dev@lists.fd.io" Subject: [vpp-dev] FW: Cov

Re: [vpp-dev] FW: Coverity build failed with 18 errors

2017-11-10 Thread Neale Ranns (nranns)
Hi Chris, And this one for VOM: https://gerrit.fd.io/r/#/c/9374/ /neale -Original Message- From: on behalf of "Neale Ranns (nranns)" Date: Friday, 10 November 2017 at 11:59 To: Chris Luke , "vpp-dev@lists.fd.io" Subject: Re: [vpp-dev] FW: Coverity build failed with 18 errors

Re: [vpp-dev] FW: Coverity build failed with 18 errors

2017-11-10 Thread Luke, Chris
Thanks Neale; merged. Hopefully normal service will be resumed on this afternoons run! :) Chris. > -Original Message- > From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On > Behalf Of Neale Ranns (nranns) > Sent: Friday, November 10, 2017 7:33 > To: Chris Luke ; vpp

Re: [vpp-dev] FW: Coverity build failed with 18 errors

2017-11-10 Thread Neale Ranns (nranns)
Hi Chris, Thank you. Please let me know if the build remains on strike ☺ /neale -Original Message- From: "Luke, Chris" Date: Friday, 10 November 2017 at 14:53 To: "Neale Ranns (nranns)" , Chris Luke , "vpp-dev@lists.fd.io" Subject: RE: [vpp-dev] FW: Coverity build failed with 18 erro

[vpp-dev] ACL Build/Test Issues

2017-11-10 Thread Jon Loeliger
Folks, Every error from the ACL implementation is -1. Generically bad. Without regard for what might be more useful to an upper-layer UI. So I submitted a patch to help this situation some. https://gerrit.fd.io/r/#/c/9383/ I have built and tested it locally, but it fails the Verify Tests becaus

Re: [vpp-dev] ACL Build/Test Issues

2017-11-10 Thread Andrew Yourtchenko
Hi Jon, > On 10 Nov 2017, at 23:11, Jon Loeliger wrote: > > Folks, > > Every error from the ACL implementation is -1. Generically bad. > Without regard for what might be more useful to an upper-layer UI. When we discussed with the openstack folks the way they are treating errors was all as c

[vpp-dev] make test-all

2017-11-10 Thread Brian Brooks
Should "make test-all" pass? Thanks, Brian IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for

Re: [vpp-dev] ACL Build/Test Issues

2017-11-10 Thread Jon Loeliger
On Fri, Nov 10, 2017 at 5:54 PM, Andrew Yourtchenko wrote: > Hi Jon, > > On 10 Nov 2017, at 23:11, Jon Loeliger wrote: > > Folks, > > Every error from the ACL implementation is -1. Generically bad. > Without regard for what might be more useful to an upper-layer UI. > > > When we discussed with

Re: [vpp-dev] ACL Build/Test Issues

2017-11-10 Thread Luke, Chris
Since the tests reside in the same repo and they’re run from the checkout copy of the patch, you should be able to simply update the tests in the same patch that changes the result codes, without need for backward compatibility. If you’re wondering where the tests are: $ ls test/*acl* test/test

Re: [vpp-dev] ACL Build/Test Issues

2017-11-10 Thread Jon Loeliger
Chris, On Fri, Nov 10, 2017 at 8:27 PM, Luke, Chris wrote: > If you’re wondering where the tests are: > > > > $ ls test/*acl* > > test/test_acl_plugin_conns.py test/test_acl_plugin_macip.py > > test/test_acl_plugin_l2l3.py test/test_acl_plugin.py > Ah, excellent! > Chris. > Thanks! jdl _