Re: [vpp-dev] move to clang-format

2020-12-17 Thread Dave Barach
From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io Sent: Thursday, December 17, 2020 1:29 PM To: Jon Loeliger via lists.fd.io Cc: vpp-dev Subject: Re: [vpp-dev] move to clang-format On 17.12.2020., at 19:06, Jon Loeliger via lists.fd.io mailto:jdl=netgate

Re: [vpp-dev] move to clang-format

2020-12-17 Thread Damjan Marion via lists.fd.io
> > On 17.12.2020., at 19:06, Jon Loeliger via lists.fd.io > wrote: > >  > > >> On Sun, Dec 13, 2020 at 6:15 AM Damjan Marion via lists.fd.io >> wrote: >> >> Hi, >> >> I was playing a bit with clang-format as replacement to gnu indent which we >> use today[1]. >> >> While it is impos

Re: [vpp-dev] move to clang-format

2020-12-17 Thread Jon Loeliger via lists.fd.io
On Sun, Dec 13, 2020 at 6:15 AM Damjan Marion via lists.fd.io wrote: > > Hi, > > I was playing a bit with clang-format as replacement to gnu indent which > we use today[1]. > > While it is impossible to render exact same result like gnu indent, good > thing is that clang-format can be used only o

Re: [vpp-dev] move to clang-format

2020-12-16 Thread Neale Ranns via lists.fd.io
+1. /neale From: on behalf of Florin Coras Date: Wednesday 16 December 2020 at 16:14 To: Damjan Marion Cc: vpp-dev Subject: Re: [vpp-dev] move to clang-format +1 Florin On Dec 16, 2020, at 6:12 AM, Damjan Marion via lists.fd.io<http://lists.fd.io> mailto:dmarion=me@lists

Re: [vpp-dev] move to clang-format

2020-12-16 Thread Florin Coras
+1 Florin > On Dec 16, 2020, at 6:12 AM, Damjan Marion via lists.fd.io > wrote: > > > Any feedback? > > Any good reason not to do the switch now when we have stable/2101 created? > > Thanks, > > Damjan > > >> On 14.12.2020., at 09:32, Benoit Ganne (bganne) wrote: >> >> Sounds good to m

Re: [vpp-dev] move to clang-format

2020-12-16 Thread Jerome Tollet via lists.fd.io
Yes please! De : au nom de "Damjan Marion via lists.fd.io" Répondre à : "dmar...@me.com" Date : mercredi 16 décembre 2020 à 15:12 À : vpp-dev Objet : Re: [vpp-dev] move to clang-format Any feedback? Any good reason not to do the switch now when we have stable/2

Re: [vpp-dev] move to clang-format

2020-12-16 Thread Dave Wallace
+1 On 12/16/2020 9:13 AM, Dave Barach wrote: Seems like a good time to flip the switch... Thanks... Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io Sent: Wednesday, December 16, 2020 9:12 AM To: vpp-dev Subject: Re: [vpp-dev] move to

Re: [vpp-dev] move to clang-format

2020-12-16 Thread Dave Barach
Seems like a good time to flip the switch... Thanks... Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io Sent: Wednesday, December 16, 2020 9:12 AM To: vpp-dev Subject: Re: [vpp-dev] move to clang-format Any feedback? Any good reason not to

Re: [vpp-dev] move to clang-format

2020-12-16 Thread Damjan Marion via lists.fd.io
Any feedback? Any good reason not to do the switch now when we have stable/2101 created? Thanks, Damjan > On 14.12.2020., at 09:32, Benoit Ganne (bganne) wrote: > > Sounds good to me, clang-format should be more consistent than indent... > > ben > >> -Original Message- >> From: vp

Re: [vpp-dev] move to clang-format

2020-12-14 Thread Benoit Ganne (bganne) via lists.fd.io
Sounds good to me, clang-format should be more consistent than indent... ben > -Original Message- > From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion > via lists.fd.io > Sent: dimanche 13 décembre 2020 13:16 > To: vpp-dev > Subject: [vpp-dev] move to clang-format > > > Hi, > > I w

Re: [vpp-dev] move to clang-format

2020-12-13 Thread Christian Hopps
> On Dec 13, 2020, at 7:15 AM, Damjan Marion via lists.fd.io > wrote: > > > Hi, > > I was playing a bit with clang-format as replacement to gnu indent which we > use today[1]. > > While it is impossible to render exact same result like gnu indent, good > thing is that clang-format can be

Re: [vpp-dev] move to clang-format

2020-12-13 Thread Dave Barach
Let me help with a sales pitch for pool_foreach2(): in this form one can set gdb breakpoints in the loop body. All by itself, that's a good enough reason to switch... Thanks for this one! Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io Se