Re: [vpp-dev] moniter interface is not correct#vnet

2022-07-19 Thread Pim van Pelt
patchset #3 and commit message updated, thanks as well to Ben for the hint that the feed of 32b into a consumer of 64b is the root cause. 36703 should be good now. On Tue, Jul 19, 2022 at 10:56 AM wrote: > This change doesn't look right either. > We should

Re: [vpp-dev] moniter interface is not correct#vnet

2022-07-19 Thread aihua1980
This change doesn't look right either. We should use u64 instead of u32. like this: vlib_cli_output ( vm, "rx: %Upps %Ubps tx: %Upps %Ubps", format_base10, (u64) ((vrx[spin].packets - vrx[spin ^ 1].packets) / tsd), format_base10, (u64) (8 * (vrx[spin].bytes - vrx[spin ^ 1].bytes) / tsd), format_b

Re: [vpp-dev] moniter interface is not correct#vnet

2022-07-19 Thread Pim van Pelt
Hoi, I can see a number of bugs here, they are all present at HEAD also. - as you called out, format_base10 expects uword but we send it u32 - we talk about bytes/sec delta but call it 'bps', which should be either *8 or 'Bps' - And what's that %c doing there at the end of the string? :) Luckily