> With gigabytes of memory used for pools and other datastructs, node
> memory structure overhead is negligible imho.
Fair enough :)
> Check the acl plugin. I have 8 nodes
> and only one instance of actual “code”. Not to say that it works perfect but
> maintenance wise it is quite reasonable.
Ag
On 24 Jan 2019, at 14:45, Benoit Ganne (bganne) wrote:
>>> 4) keeps the 3 flavors as they are but add helper to register
>>> nodes to the 3 arcs - basically move helpers from GBP plugin to vnet/l2.
>>> Basically same up/downside as (3)
>
>> This would be my favourite approach. The benefit of h
>> 4) keeps the 3 flavors as they are but add helper to register
>> nodes to the 3 arcs - basically move helpers from GBP plugin to vnet/l2.
>> Basically same up/downside as (3)
> This would be my favourite approach. The benefit of having per-arc nodes is
> that we can get compiler optimizations b
> On 24 Jan 2019, at 11:16, Damjan Marion via Lists.Fd.Io
> wrote:
>
>
>
>> On 24 Jan 2019, at 10:39, Benoit Ganne (bganne) via Lists.Fd.Io
>> wrote:
>>
>> Hi all,
>>
>> While refactoring the GBP plugin to use feature arcs instead of hardcoded L2
>> feature bits, I had to basically dupl
> Let's say you have l2 acl which sits on ip4 arc and yout gbp node which sits
> on
> "all" arc.
> What will be the packet flow, and how you can say who is 1st?
Good point. You cannot order nodes between arcs, so GBP could not say "runs
before acl" in that case.
This would basically be dictated
> On 24 Jan 2019, at 11:37, Benoit Ganne (bganne) wrote:
>
>>> 1) add a new feature arc flavor 'all' alongside nonip, ip4 and ip6.
>>> Nodes on this arc will gets all packets regardless of the headers. It keeps
>>> backward compat but should add a small performance hit when L2 feature
>>> arcs
>> 1) add a new feature arc flavor 'all' alongside nonip, ip4 and ip6.
>> Nodes on this arc will gets all packets regardless of the headers. It keeps
>> backward compat but should add a small performance hit when L2 feature
>> arcs are enabled (we have to visit 4 feature arcs instead of 3). This is
> On 24 Jan 2019, at 10:39, Benoit Ganne (bganne) via Lists.Fd.Io
> wrote:
>
> Hi all,
>
> While refactoring the GBP plugin to use feature arcs instead of hardcoded L2
> feature bits, I had to basically duplicate my feature arc nodes 3x (and
> disable/enable them 3x etc.) because the L2 fea
