Re: [vpp-dev] Enable DPDK tx offload flag mbuf-fast-free on VPP vector mode

2021-09-22 Thread Jieqiang Wang
) ; vpp-dev ; Lijian Zhang ; Honnappa Nagarahalli ; Govindarajan Mohandoss ; Ruifeng Wang ; Tianyu Li ; Feifei Wang ; nd Subject: Re: [vpp-dev] Enable DPDK tx offload flag mbuf-fast-free on VPP vector mode — Damjan On 22.09.2021., at 11:50, Jieqiang Wang mailto:jieqiang.w...@arm.com

Re: [vpp-dev] Enable DPDK tx offload flag mbuf-fast-free on VPP vector mode

2021-09-22 Thread Damjan Marion via lists.fd.io
— Damjan > On 22.09.2021., at 11:50, Jieqiang Wang wrote: > > Hi Ben, > > Thanks for your quick feedback. A few comments inline. > > Best Regards, > Jieqiang Wang > > -Original Message- > From: Benoit Ganne (bganne) > Sent: Friday, September 17, 2021 3:34 PM > To: Jieqiang Wang ;

Re: [vpp-dev] Enable DPDK tx offload flag mbuf-fast-free on VPP vector mode

2021-09-22 Thread Jieqiang Wang
Hi Ben, Thanks for your quick feedback. A few comments inline. Best Regards, Jieqiang Wang -Original Message- From: Benoit Ganne (bganne) Sent: Friday, September 17, 2021 3:34 PM To: Jieqiang Wang ; vpp-dev Cc: Lijian Zhang ; Honnappa Nagarahalli ; Govindarajan Mohandoss ; Ruifeng Wa

Re: [vpp-dev] Enable DPDK tx offload flag mbuf-fast-free on VPP vector mode

2021-09-17 Thread Benoit Ganne (bganne) via lists.fd.io
Hi Jieqiang, This looks like an interesting optimization but you need to check that the 'mbufs to be freed should be coming from the same mempool' rule holds true. This won't be the case on NUMA systems (VPP creates 1 buffer pool per NUMA). This should be easy to check with eg. 'vec_len (vm->buf