Re: [vpp-dev] vppinfra vec alignment

2018-12-14 Thread Dave Wallace
No worries. FYI, it would have been fine to just submit a patch to my original gerrit review.  Best if both changes are submitted in a single commit to document the replication of information that needs to be maintained. Thanks, -daw- On 12/14/2018 10:15 AM, Mohammed Alshohayeb wrote: I've

Re: [vpp-dev] vppinfra vec alignment

2018-12-14 Thread Mohammed Alshohayeb
I've already submitted a patch yesterday, I guess I should have communicated it, my bad https://gerrit.fd.io/r/#/c/16470/ ⁣ On Dec 14, 2018, 5:19 PM, at 5:19 PM, Dave Wallace wrote: > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11610): https

Re: [vpp-dev] vppinfra vec alignment

2018-12-14 Thread Dave Barach via Lists.Fd.Io
: [vpp-dev] vppinfra vec alignment Submitted patch 2 to [1] updating the doxygen tag in .../src/vppinfra/vec.h Thanks, -daw- On 12/13/2018 3:06 PM, Dave Barach (dbarach) wrote: Thanks for this one... If you can spare the time, please fix the doxygen tag / comment in .../src/vppinfra/vec.h... From

Re: [vpp-dev] vppinfra vec alignment

2018-12-14 Thread Dave Wallace
Behalf Of *Dave Wallace *Sent:* Thursday, December 13, 2018 12:33 PM *To:* dmar...@me.com; Mohammed Alshohayeb *Cc:* vpp-dev@lists.fd.io *Subject:* Re: [vpp-dev] vppinfra vec alignment I have submitted a patch [1] to update the documentation per this email thread. Thanks, -daw- [1] https

Re: [vpp-dev] vppinfra vec alignment

2018-12-13 Thread Dave Barach via Lists.Fd.Io
-dev] vppinfra vec alignment I have submitted a patch [1] to update the documentation per this email thread. Thanks, -daw- [1] https://gerrit.fd.io/r/16467 On 12/12/2018 4:54 PM, Damjan Marion via Lists.Fd.Io wrote: That should be corrected to: Users may specify the alignment for first data

Re: [vpp-dev] vppinfra vec alignment

2018-12-13 Thread Dave Wallace
I have submitted a patch [1] to update the documentation per this email thread. Thanks, -daw- [1] https://gerrit.fd.io/r/16467 On 12/12/2018 4:54 PM, Damjan Marion via Lists.Fd.Io wrote: That should be corrected to: Users may specify the alignment for* first data element *via the vec*_align

Re: [vpp-dev] vppinfra vec alignment

2018-12-12 Thread Damjan Marion via Lists.Fd.Io
That should be corrected to: Users may specify the alignment for first data element via the vec*_aligned macros. Other elementa will be alligned only is data structure is alligned, i.e. By CLIB_CACHELINE_ALIGN_MARK(...) macro... — Damjan > On Dec 12, 2018, at 2:04 PM, Mohammed Alshohayeb wr

[vpp-dev] vppinfra vec alignment

2018-12-12 Thread Mohammed Alshohayeb
Hello everyone, >From what I understand and see that the vec_*_aligned restriction is for the vector hdr/userhdr not the individual elements, however, this page says Typically, the user header is not present