Re: [vpp-dev] vnet_rename_interface()

2021-05-14 Thread Paul Vinciguerra
Hi Dave, I started out saying that I think this is a valuable change. That being said, this is going to have implications for folks. Sometimes concrete examples help. I did not have to look far. Here is code from VOM. Yes, it is deprecated, but it is an example for folks to follow. /** * A DB

Re: [vpp-dev] vnet_rename_interface()

2021-05-13 Thread Dave Cornejo via lists.fd.io
Ole, As you note, internally only the index is used. As far as I can tell, the ability to store the name in VPP is a convenience. The ability to change it shouldn't impact VPP but makes it much easier for those of us that have to deal with the human side of a product. The change to expose it is min

Re: [vpp-dev] vnet_rename_interface()

2021-05-05 Thread Nathan Skrzypczak
Hi Paul, >From my understanding - but I might be mistaken here - I thought this was about an explicit `rename` cli & api, so foot shooting would be quite explicit from the user's perspective. On ability to query/disable `show int` and equivalent apis would return this modified state, and not calli

Re: [vpp-dev] vnet_rename_interface()

2021-05-05 Thread Paul Vinciguerra
Hi Matt, Ole, Nathan, Matt, I have no objection to the feature, I would just ask that you provide a startup.conf option to disable it and an api to query that state. The reason I say this is that there are configuration models that depend on the stability of the device name. Many yang models as a

Re: [vpp-dev] vnet_rename_interface()

2021-05-05 Thread Nathan Skrzypczak
Hi Matt, Hi Ole, I think adding a cli & api call for renaming interfaces would be quite useful. I agree we shouldn't refer to interfaces by name in the API thought (sw_if_index is definitely the way to go) Several non-api use-cases would imho benefit from this. I can see writing cli scripts witho

Re: [vpp-dev] vnet_rename_interface()

2021-05-05 Thread Ole Troan
Matt, > Source file src/vnet/interface.c has a function vnet_rename_interface(). It > only appears to be called by the lisp plugin currently. It would be handy to > be able to rename a DPDK interface without having to change startup.conf and > restart VPP. I am wondering if I could do that by a

[vpp-dev] vnet_rename_interface()

2021-05-04 Thread Matthew Smith via lists.fd.io
Hi all, Source file src/vnet/interface.c has a function vnet_rename_interface(). It only appears to be called by the lisp plugin currently. It would be handy to be able to rename a DPDK interface without having to change startup.conf and restart VPP. I am wondering if I could do that by adding a s