Re: [vpp-dev] session hash leak

2020-05-29 Thread Florin Coras
Hi Andreas, Unfortunately, the proxy sample app has not been tested under heavy load. It’s just an example test app. If you have a patch, please do push it to avoid the issue in the future. Otherwise, I’ll take a look at it. Regards, Florin > On May 29, 2020, at 6:29 AM, Andreas Schultz

Re: [vpp-dev] session hash leak

2020-05-29 Thread Andreas Schultz
Hi, Tracked it down. It's not the session logic, but the connection handling in the proxy sample hs_app. The proxy is calling vnet_disconnect_session on both sessions in delete_proxy_session. That function is invoked from the disconnect and reset callback. Turns out that calling vnet_disconnect_s

Re: [vpp-dev] session hash leak

2020-05-29 Thread Florin Coras
Hi Andreas, The session hash table entry is cleaned up by session_delete, unless the transport has somehow been altered and the lookup fails. Obviously the transport should be still intact in closed state, hence the delete notification. Do you see the warning message that the hash cannot be de

[vpp-dev] session hash leak

2020-05-29 Thread Andreas Schultz
Hi, It seems that the {v4,v6}_session_hash is leaking entries. When creating large amounts of TCP session (incoming and outgoing) we are observing entries in the session_hash pointing to already deleted sessions. I have verified with a somewhat hackish check in session_delete that sometimes a ses