Re: [vpp-dev] event-logger output format

2019-11-01 Thread Dave Barach via Lists.Fd.Io
ect: Re: [vpp-dev] event-logger output format Dave, Thanks for your explanation! In my opinion, it depends on what the "is_mp_safe" flag actually means. If all the functions are actually thread-safe and these barrier synchronization calls are required mainly for debugging, then

Re: [vpp-dev] event-logger output format

2019-11-01 Thread Aleksander Djuric
Dave, Thanks for your explanation! In my opinion, it depends on what the "is_mp_safe" flag actually means. If all the functions are actually thread-safe and these barrier synchronization calls are required mainly for debugging, then I suggest the following: #if CLIB_DEBUG > 0 if (!c->is_mp_safe

Re: [vpp-dev] event-logger output format

2019-10-31 Thread Balaji Venkatraman via Lists.Fd.Io
. From: "Dave Barach (dbarach)" Date: Thursday, October 31, 2019 at 12:27 PM To: "Balaji Venkatraman (balajiv)" , "vpp-dev@lists.fd.io" Subject: RE: [vpp-dev] event-logger output format Two cases: in single-core operation, debug CLI commands change the NDR / max thro

Re: [vpp-dev] event-logger output format

2019-10-31 Thread Dave Barach via Lists.Fd.Io
ric ; vpp-dev@lists.fd.io Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] event-logger output format Do you think it would be prudent to publish a ‘warning’ message on its impact on packet forwarding when this cmd is used? Thanks! -- Regards, Balaji. From: mailto:vpp-dev@lists.fd.io>&g

Re: [vpp-dev] event-logger output format

2019-10-31 Thread Balaji Venkatraman via Lists.Fd.Io
Do you think it would be prudent to publish a ‘warning’ message on its impact on packet forwarding when this cmd is used? Thanks! -- Regards, Balaji. From: on behalf of Aleksander Djuric Date: Thursday, October 31, 2019 at 8:07 AM To: "vpp-dev@lists.fd.io" Subject: Re: [vpp-

Re: [vpp-dev] event-logger output format

2019-10-31 Thread Aleksander Djuric
Sample output: > > vpp# show event-logger 2 > 82 of 131072 events in buffer, logger running > 19.946551561: api-msg: trace_plugin_msg_ids > 19.946557011: api-msg-done(mp-safe): trace_plugin_msg_ids > vpp# show event-logger 2 no-delta > 82 of 131072 events in buffer, logger running > 1572533201.20

Re: [vpp-dev] event-logger output format

2019-10-31 Thread Aleksander Djuric
Hi Dave, Thanks! Now it looks like this: > show event-logger [all] [] [delta|no-delta|date-time] Updated patch: https://gerrit.fd.io/r/c/vpp/+/23146 On Thu, Oct 31, 2019 at 04:47 PM, Dave Barach wrote: > > > > Yes, we see things differently. I never look at elog data in the debug > CLI. I sa

Re: [vpp-dev] event-logger output format

2019-10-31 Thread Dave Barach via Lists.Fd.Io
with a full timestamp. Maybe add “[delta|no-delta]” qualifier keywords to the debug CLI command. FWIW... Dave From: vpp-dev@lists.fd.io On Behalf Of Aleksander Djuric Sent: Thursday, October 31, 2019 8:42 AM To: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] event-logger output format Hi Dave

Re: [vpp-dev] event-logger output format

2019-10-31 Thread Aleksander Djuric
Hi Dave, Thank you very much for your reply. I think it can be useful to discuss this patch here at first. As I see, we looks at these things little bit differently ) I'm use event-logger mostly for registering such fast events as ACL filter matching. I think that the human-readable format is be

Re: [vpp-dev] event-logger output format

2019-10-31 Thread Dave Barach via Lists.Fd.Io
/ minuend widths when asking questions of the form “how long does the XYZ API message handler take?” FWIW... Dave From: vpp-dev@lists.fd.io On Behalf Of Aleksander Djuric Sent: Thursday, October 31, 2019 2:56 AM To: vpp-dev@lists.fd.io Subject: [vpp-dev] event-logger output format Hi all, In my

[vpp-dev] event-logger output format

2019-10-30 Thread Aleksander Djuric
Hi all, In my opinion, the event-logger cli command has uncomfortable format of output. I have small suggestion about it. I think that the event-logger output should be printed in following manner: vpp# show event-logger > 72 of 131072 events in buffer, logger running > 2019/10/31 09:18:36:937: a