Re: [vpp-dev] crash in new QoS code

2016-11-09 Thread David Hotham via vpp-dev
Hello, I'd like to come back to this one. As below, the problem is that sometimes VPP's control thread generates eg ARP packets; and the HQoS code is not ready for this. I've submitted a proposed fix that checks: are we on an unexpected thread? And if so, skips the HQoS queueing. https://ger

Re: [vpp-dev] crash in new QoS code

2016-10-11 Thread Neale Ranns
p-dev-boun...@lists.fd.io] On Behalf Of Neale Ranns (nranns) Sent: Tuesday, October 11, 2016 1:16 PM To: David Hotham; vpp-dev@lists.fd.io; Singh, Jasvinder (jasvinder.si...@intel.com); Dumitrescu, Cristian (cristian.dumitre...@intel.com) Subject: Re: [vpp-dev] crash in new QoS code Hi David, On 11/1

Re: [vpp-dev] crash in new QoS code

2016-10-11 Thread John Lo (loj)
Singh, Jasvinder (jasvinder.si...@intel.com); Dumitrescu, Cristian (cristian.dumitre...@intel.com) Subject: Re: [vpp-dev] crash in new QoS code Hi David, On 11/10/16 15:36, David Hotham via vpp-dev wrote: > So back on the original crash that started this thread... I've been > doing some

Re: [vpp-dev] crash in new QoS code

2016-10-11 Thread Neale Ranns
Hi David, On 11/10/16 15:36, David Hotham via vpp-dev wrote: So back on the original crash that started this thread… I’ve been doing some digging, have a decent idea of what’s going wrong, and would appreciate input on what the right approach / next steps towards fixing it should be. When th

Re: [vpp-dev] crash in new QoS code

2016-10-11 Thread David Hotham via vpp-dev
My startup.conf currently contains this: cpu { main-core 0 corelist-workers 1 corelist-hqos-threads 2, 3 } David From: Singh, Jasvinder [mailto:jasvinder.si...@intel.com] Sent: 11 October 2016 16:25 To: David Hotham; vpp-dev@lists.fd.io; Dumitrescu, Cristian Subject: RE: crash in new QoS c

Re: [vpp-dev] crash in new QoS code

2016-10-11 Thread Singh, Jasvinder
As I mentioned earlier, hqos thread runs only qos scheduler. In the configuration below, I don't see any logical core assigned to main/worker thread ? From: David Hotham [mailto:david.hot...@metaswitch.com] Sent: Tuesday, October 11, 2016 3:37 PM To: vpp-dev@lists.fd.io; Singh, Jasvinder ; Dum

Re: [vpp-dev] crash in new QoS code

2016-10-11 Thread David Hotham via vpp-dev
So back on the original crash that started this thread... I've been doing some digging, have a decent idea of what's going wrong, and would appreciate input on what the right approach / next steps towards fixing it should be. When the GRE tunnel is configured, VPP's main control thread causes a