Re: [vpp-dev] String tests failures

2018-12-06 Thread Dave Barach via Lists.Fd.Io
p-dev@lists.fd.io Subject: Re: [vpp-dev] String tests failures Dave, I was able to verify that the fix works and thus removed the test from https://gerrit.fd.io/r/#/c/16282/. Thanks From: Dave Barach (dbarach) [mailto:dbar...@cisco.com] Sent: Wednesday, December 5, 2018 2:52 PM To: Lijian Zhang

Re: [vpp-dev] String tests failures

2018-12-06 Thread Juraj Linkeš
Dave, I was able to verify that the fix works and thus removed the test from https://gerrit.fd.io/r/#/c/16282/. Thanks From: Dave Barach (dbarach) [mailto:dbar...@cisco.com] Sent: Wednesday, December 5, 2018 2:52 PM To: Lijian Zhang (Arm Technology China) Cc: Juraj Linkeš ; Damjan Marion ; Ste

Re: [vpp-dev] String tests failures

2018-12-05 Thread Dave Barach via Lists.Fd.Io
See https://gerrit.fd.io/r/#/c/16352, which computes strlen if necessary for a precise copy-overlap check. Strncpy_s was always slightly wrong in this regard. The "make test" failure showed up [only] on aarch64 due to test code stack variable placement / alignment differences between aarch64 and