Re: [vpp-dev] Some NAT API Error Values

2022-11-26 Thread filvarga
Hi, https://gerrit.fd.io/r/c/vpp/+/37695 Here you go: FEATURE_ALREADY_DISABLED FEATURE_ALREADY_ENABLED There is much work to be done on the error tracking side of the whole nat api though. I wouldn't rely to much on specific errors more on failure / success for now. Best regards, Filip Varga

Re: [vpp-dev] Some NAT API Error Values

2022-11-23 Thread filvarga
Hi, I understand your perspective. But you have to think in a longer perspective of NAT changes. The concept of enabling / disabling plugins on the go is not super common among VPP. This was just an addition for SDN deployments so configuration through startup config can be avoided and reallocatio

Re: [vpp-dev] Some NAT API Error Values

2022-11-23 Thread Jon Loeliger via lists.fd.io
On Wed, Nov 23, 2022 at 12:25 PM filvarga wrote: > Hi, > > Thank you for your notes and pointing out the issue. Feel free to submit > any changes in the future and add appropriate people to your review (based > on maintainers list). > Thanks, will do! For now I am posting a quick fix. As the na

Re: [vpp-dev] Some NAT API Error Values

2022-11-23 Thread filvarga
Hi, Thank you for your notes and pointing out the issue. Feel free to submit any changes in the future and add appropriate people to your review (based on maintainers list). For now I am posting a quick fix. As the nat44-ed control plane is undergoing a continuous huge refactor I wouldn't advise t

[vpp-dev] Some NAT API Error Values

2022-11-23 Thread Jon Loeliger via lists.fd.io
Hi VPPeople, I would like to open a discussion about some strange code and return values from a few of the NAT CLI and API interface functions. My quest for a reasonable handling when my management plane attempted to enable an already-enabled NAT 44 ED feature was handled poorly. It turns out, r