Re: [vpp-dev] Set of the small bug-fixes for #vpp

2020-01-13 Thread Ole Troan
Aleksander, > Sorry, you are absolutely right. It's no issues here. In my VPP v19.08-stable > I have no commit 75761b93. Thanks, that was good to hear! Best regards, Ole -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#15144): https://lists.fd.io

Re: [vpp-dev] Set of the small bug-fixes for #vpp

2020-01-13 Thread Aleksander Djuric
Sorry, you are absolutely right. It's no issues here. In my VPP v19.08-stable I have no commit 75761b93. Thanks! Aleksander -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#15143): https://lists.fd.io/g/vpp-dev/message/15143 Mute This Topic: https://

Re: [vpp-dev] Set of the small bug-fixes for #vpp

2020-01-13 Thread Ole Troan
Hi Aleksander, > Yes. This fix still needed. Please take a look at the test below: > > > import ipaddress > > ipaddress.IPv4Network((u'192.168.0.222', 24), False) > IPv4Network(u'192.168.0.0/24') > > The IPv4Network method should not be used here, because in functions like an > ip_address_dump

Re: [vpp-dev] Set of the small bug-fixes for #vpp

2020-01-13 Thread Aleksander Djuric
Yes. This fix still needed. Please take a look at the test below: > import ipaddress > ipaddress.IPv4Network(( u'192.168.0.222' , 24 ), False ) IPv4Network(u'192.168.0.0/24') The IPv4Network method should not be used here, because in functions like an  ip_address_dump or ip_route_dump we expect t

Re: [vpp-dev] Set of the small bug-fixes for #vpp

2020-01-13 Thread Aleksander Djuric
On Mon, Jan 13, 2020 at 01:20 PM, Ole Troan wrote: > > would you mind elaborating why you want the Python representation of an IP > prefix to be a dictionary of address and length as opposed to an > IPv6Network/IPv4Network object? Hi Ole! Thanks! It's strange, but the IPv[46]Network method some

Re: [vpp-dev] Set of the small bug-fixes for #vpp

2020-01-13 Thread Ole Troan
Hi Aleksander, > 3) vpp_papi: correct unformat ip address for ip_address_dump, ip_route_dump, > etc (unformat-api-prefix.patch) would you mind elaborating why you want the Python representation of an IP prefix to be a dictionary of address and length as opposed to an IPv6Network/IPv4Network ob

[vpp-dev] Set of the small bug-fixes for #vpp

2020-01-13 Thread Aleksander Djuric
Hello Everyone, I have a small set of the fixes for VPP, but unfortunatelly right now, I have no time for pushing the code with git review. I hope that these fixes are very useful for the project and I would be very happy if someone could do it instead of me. In any case I hope that these fixes