Re: [vpp-dev] Port range in ACL hash lookup

2017-08-10 Thread Soroosh Sardari
Dear Andrew, Thanks for adding me to reviewer of the gerrit task, I checked my gerrit account it's already reviewed and merged. Thanks for such a fast response. Cheers, Soroosh On Aug 10, 2017 8:20 PM, "Andrew 👽 Yourtchenko" wrote: > Dear Soroosh, > > I have added you as a reviewer to https://

Re: [vpp-dev] Port range in ACL hash lookup

2017-08-10 Thread Andrew 👽 Yourtchenko
Dear Soroosh, I have added you as a reviewer to https://gerrit.fd.io/r/#/c/7983/ --a On 8/10/17, Andrew 👽 Yourtchenko wrote: > Dear Soroosh, > > Thanks for catching, I think you are right! > > The assignment should come from curr_index rather than > result_val->applied_entry_index..., and the

Re: [vpp-dev] Port range in ACL hash lookup

2017-08-10 Thread Andrew 👽 Yourtchenko
Dear Soroosh, Thanks for catching, I think you are right! The assignment should come from curr_index rather than result_val->applied_entry_index..., and the non-shadowed check just below will not apply, so would need to be deleted. Before getting the fix in, let me see how I can enhance the unit

[vpp-dev] Port range in ACL hash lookup

2017-08-10 Thread Soroosh Sardari
Dear vpp folks, There is an ambiguity for me in 'multi_acl_match_get_applied_ace_index' function in 'hash_lookup.c' when port-range check is true. After finding an ace with matched port range, why we do not assign curr_index to curr_match_index? The following code snippet is the lines I refered a