Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h

2017-03-31 Thread Dave Barach (dbarach)
-dev] Out of Tree Build Failure on vnet/rewrite.h On Fri, Mar 31, 2017 at 7:34 AM, Jim Thompson mailto:j...@netgate.com>> wrote: Either that, or Cisco moves to builds apps the same way. You guys & gals break the tree for us about twice per month lately. Hi VPP-ites, That's maybe

Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h

2017-03-31 Thread Jon Loeliger
On Fri, Mar 31, 2017 at 10:05 AM, Kinsella, Ray wrote: > Would this TC cover the actual problem though, as I though in this case > the header was never "installed". But it was referenced. So, I believe it would have worked. jdl ___ vpp-dev mailing l

Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h

2017-03-31 Thread Kinsella, Ray
Would this TC cover the actual problem though, as I though in this case the header was never "installed". Ray K On 31/03/2017 14:46, Burt Silverman wrote: Exported is the wrong word. I meant "installed." ​ ___ vpp-dev mailing list vpp-dev@lists.fd.

Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h

2017-03-31 Thread Burt Silverman
Exported is the wrong word. I meant "installed." ​ ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h

2017-03-31 Thread Burt Silverman
I guess this time it was the out of tree rather than the tree itself that got broken. One could make a test file, vaguely like my test.c that starts off with //gcc -Wall -I. -march=native -c test.c //#include "vppinfra/types.h" //#include "vppinfra/cache.h" //#include "vppinfra/valgrind.h" //#in

Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h

2017-03-31 Thread Jon Loeliger
On Fri, Mar 31, 2017 at 7:34 AM, Jim Thompson wrote: > > Either that, or Cisco moves to builds apps the same way. You guys & gals > break the tree for us about twice per month lately. > Hi VPP-ites, That's maybe not such a bad notion. What about taking, say, the entire VAT piece out of VPP pro

Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h

2017-03-31 Thread Jim Thompson
ale > > From: Jon Loeliger > Date: Friday, 31 March 2017 at 00:15 > To: Ed Warnicke > Cc: "Neale Ranns (nranns)" , vpp-dev > Subject: Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h > > On Thu, Mar 30, 2017 at 5:42 PM, Ed Warnicke wrote: > T

Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h

2017-03-31 Thread Neale Ranns (nranns)
Ed, Is that something we can add to the verify jobs? /neale From: Jon Loeliger Date: Friday, 31 March 2017 at 00:15 To: Ed Warnicke Cc: "Neale Ranns (nranns)" , vpp-dev Subject: Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h On Thu, Mar 30, 2017 at 5:42 PM, E

Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h

2017-03-30 Thread Ni, Hongjun
Tree Build Failure on vnet/rewrite.h On Thu, Mar 30, 2017 at 5:42 PM, Ed Warnicke mailto:hagb...@gmail.com>> wrote: The more interesting (to me) question is... how did it pass verify? Ed Ed, If I might speculate, it isn't anything that the VPP Builds even checks. To catch this, you ha

Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h

2017-03-30 Thread Jon Loeliger
On Thu, Mar 30, 2017 at 5:42 PM, Ed Warnicke wrote: > The more interesting (to me) question is... how did it pass verify? > > Ed > Ed, If I might speculate, it isn't anything that the VPP Builds even checks. To catch this, you have to build VPP to packages, take those packages, install them on

Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h

2017-03-30 Thread Ed Warnicke
The more interesting (to me) question is... how did it pass verify? Ed On Thu, Mar 30, 2017 at 3:25 PM, Neale Ranns (nranns) wrote: > > > Hi Jon, > > > > Sorry about that. > > > > The files that get copied to /usr/include/bla/bla are specified in vnet.am > in nobase_include_HEADERS+=.h > > IIRC

Re: [vpp-dev] Out of Tree Build Failure on vnet/rewrite.h

2017-03-30 Thread Neale Ranns (nranns)
Hi Jon, Sorry about that. The files that get copied to /usr/include/bla/bla are specified in vnet.am in nobase_include_HEADERS+=.h IIRC in that commit I removed vnet/rewirte.h from that set. Which was evidently a mistake. https://gerrit.fd.io/r/#/c/5963/ regards, neale From: Jon Loeliger D

[vpp-dev] Out of Tree Build Failure on vnet/rewrite.h

2017-03-30 Thread Jon Loeliger
Neale, Looks like we have that situation of either: 1) An include file shouldn't be #including another one, and perhaps the latter might be needed directly in a set of .c files, or 2) The install target isn't picking up and installing one of the now-needed include f